From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 07/34] xen/common: sched_sedf: Remove unused
	functions
Date: Tue, 25 Mar 2014 17:03:21 +0000
Message-ID: <5331B6D9.10608@eu.citrix.com>
References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org>
	<1395766541-23979-8-git-send-email-julien.grall@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <George.Dunlap@citrix.com>) id 1WSUl5-0004lg-Km
	for xen-devel@lists.xenproject.org; Tue, 25 Mar 2014 17:03:27 +0000
In-Reply-To: <1395766541-23979-8-git-send-email-julien.grall@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@citrix.com, tim@xen.org, ian.campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 03/25/2014 04:55 PM, Julien Grall wrote:
> Clang 3.5 will fail to compile xen/common/sched_sedf.c because some function
> are not used:
>
> sched_sedf.c:141:20: error: unused function 'extraq_add_head' [-Werror,-Wunused-function]
> static inline void extraq_add_head(struct vcpu *d, int i)
>                         ^
> sched_sedf.c:147:20: error: unused function 'extraq_add_tail' [-Werror,-Wunused-function]
> static inline void extraq_add_tail(struct vcpu *d, int i)
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

> ---
>   xen/common/sched_sedf.c |   12 ------------
>   1 file changed, 12 deletions(-)
>
> diff --git a/xen/common/sched_sedf.c b/xen/common/sched_sedf.c
> index 7c24171..0c9011a 100644
> --- a/xen/common/sched_sedf.c
> +++ b/xen/common/sched_sedf.c
> @@ -138,18 +138,6 @@ static inline int extraq_on(struct vcpu *d, int i)
>               (EXTRALIST(d,i)->next != EXTRALIST(d,i)));
>   }
>
> -static inline void extraq_add_head(struct vcpu *d, int i)
> -{
> -    list_add(EXTRALIST(d,i), EXTRAQ(d->processor,i));
> -    ASSERT(extraq_on(d, i));
> -}
> -
> -static inline void extraq_add_tail(struct vcpu *d, int i)
> -{
> -    list_add_tail(EXTRALIST(d,i), EXTRAQ(d->processor,i));
> -    ASSERT(extraq_on(d, i));
> -}
> -
>   static inline void extraq_del(struct vcpu *d, int i)
>   {
>       struct list_head *list = EXTRALIST(d,i);
>