From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH 09/34] xen/common: tmem: Remove dumb check
 in do_tmem_destroy_pool
Date: Tue, 25 Mar 2014 18:18:21 +0000
Message-ID: <5331C86D.6070306@linaro.org>
References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org>
	<1395766541-23979-10-git-send-email-julien.grall@linaro.org>
	<5331C583.9090001@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WSVvd-0003bD-T8
	for xen-devel@lists.xenproject.org; Tue, 25 Mar 2014 18:18:26 +0000
Received: by mail-bk0-f48.google.com with SMTP id mx12so315542bkb.35
	for <xen-devel@lists.xenproject.org>;
	Tue, 25 Mar 2014 11:18:23 -0700 (PDT)
In-Reply-To: <5331C583.9090001@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com, tim@xen.org
List-Id: xen-devel@lists.xenproject.org

Hi Andrew,

I just saw that a patch was already sent few months ago
(http://lists.xenproject.org/archives/html/xen-devel/2013-11/msg03664.html),
but never upstreamed.

Konrad, I'm fine to drop this patch if you plan to send your series.

Regards,

On 03/25/2014 06:05 PM, Andrew Cooper wrote:
> On 25/03/14 16:55, Julien Grall wrote:
>> do_tmem_destroy_pool is checking if pools == NULL. But, pools is a fixed
>> array.
>>
>> Clang 3.5 will fail to compile xen/common/tmem.c with the following error:
>> tmem.c:1848:18: error: comparison of array 'client->pools' equal to a null pointer is always false [-Werror,-Wtautological-pointer-compare]
>>     if ( client->pools == NULL )
> 
> Coverity-ID:1055632
> 
> ~Andrew
> 
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> ---
>>  xen/common/tmem.c |    2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/xen/common/tmem.c b/xen/common/tmem.c
>> index 02e7e2e..0a24b3f 100644
>> --- a/xen/common/tmem.c
>> +++ b/xen/common/tmem.c
>> @@ -1845,8 +1845,6 @@ static int do_tmem_destroy_pool(uint32_t pool_id)
>>      struct client *client = current->domain->tmem_client;
>>      struct tmem_pool *pool;
>>  
>> -    if ( client->pools == NULL )
>> -        return 0;
>>      if ( pool_id >= MAX_POOLS_PER_DOMAIN )
>>          return 0;
>>      if ( (pool = client->pools[pool_id]) == NULL )
> 


-- 
Julien Grall