From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 00/34] Add clang support for ARM and cleanups Date: Tue, 25 Mar 2014 23:26:02 +0000 Message-ID: <5332108A.8020301@linaro.org> References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WSajN-0001pD-JP for xen-devel@lists.xenproject.org; Tue, 25 Mar 2014 23:26:05 +0000 Received: by mail-wi0-f173.google.com with SMTP id f8so4049002wiw.12 for ; Tue, 25 Mar 2014 16:26:04 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Stefano, On 25/03/14 18:22, Stefano Stabellini wrote: > On Tue, 25 Mar 2014, Julien Grall wrote: >> Hello all, >> >> The main goal of this patch series is to add support for Clang on ARM. >> The work has been done with Clang 3.5 which is not yet release but have >> a good support for ARM32. I think clang 3.4 may also be able to compile >> Xen but I didn't try. >> >> With the first part of the serie (patch #1-#19 and patch #33), I'm able to boot >> Xen compiled by Clang on midway. The patch #33 workaround for a bug in Clang >> (http://llvm.org/bugs/show_bug.cgi?id=19199). I'm not sure if the patch would >> be acceptable for Xen upstream. >> >> While I was working on Clang 3.5, I played with -Wmissing-prototypes (patch #20-#30) >> and discovered some exported functions which were: >> - the prototype were not declared before because of a missing include >> - never used >> >> Finally the last part of this series (patch #31-33) contains a start of >> bug fixes to be able to compile the tools with Clang. I didn't include >> the patch https://patches.linaro.org/26826/. >> >> The branch will all the patch applied (+few required patches) can be found here: >> git clone git://xenbits.xen.org/people/julieng/xen-unstable.git -b clang >> >> Any comments and questions are welcomed. > > Patches #5 #7 #8 #9 #10 #12 #16 #17 #18 #20 #21 #22 #23 #24 #25 #26 #28 > #29 are correct and I think they should be applied. > You can add my reviewed-by to them. Thanks for your review. FYI, every patches can be applied separately. Regards, -- Julien Grall