From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSkWt-0006MT-61 for qemu-devel@nongnu.org; Wed, 26 Mar 2014 05:53:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSkWj-0004mX-Ge for qemu-devel@nongnu.org; Wed, 26 Mar 2014 05:53:50 -0400 Received: from mail-ee0-x233.google.com ([2a00:1450:4013:c00::233]:42690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSkWj-0004mK-9P for qemu-devel@nongnu.org; Wed, 26 Mar 2014 05:53:41 -0400 Received: by mail-ee0-f51.google.com with SMTP id c13so1442033eek.10 for ; Wed, 26 Mar 2014 02:53:40 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5332A39F.6010609@redhat.com> Date: Wed, 26 Mar 2014 10:53:35 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1395775613-30984-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1395775613-30984-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [maybe-for-2.0 0/2] hw/arm: Don't specify any default board List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org Il 25/03/2014 20:26, Peter Maydell ha scritto: > Currently for both qemu-system-arm and qemu-system-aarch64 > the default board model if the user doesn't specify one > is the 'integratorcp'. This is a totally arbitrary historical > accident since it was the first board to be modelled. > That board is now just one target among many for us, and > is a very poor choice of default: > * it's an ancient board that is now only found in the > junkpiles of longtime ARM/Linux hackers, if at all > * it's an ARMv5 CPU, when most distros are now assuming ARMv7 > * it's pretty much unmaintained in QEMU > * it doesn't even have versatilepb's advantage of supporting PCI > > Making it or any other board the default serves only to confuse > people new to ARM who expect something more like the x86 monoculture, > and try to run a Linux kernel built for some random devboard on > QEMU's integratorcp model by mistake > > This series removes the is_default marker from integratorcp, > to give users a nudge that they need to think about which board > they want a QEMU model of. > > Since it's now more likely that users will hit it, patch 2 > improves the slightly cryptic error "No machine found." to > align with the rather more helpful text produced if you ask > -M no-such-machine. > > This is a little late in the 2.0 cycle, but on the other hand > the patches themselves are trivially simple, and the only > question really is if we want to do this. It does break > backwards compatibility of command lines with anybody who > is still really running integratorcp kernels and not bothering > to specify "-M integratorcp". But 2.0 is a nice round number > to do that, and I think we improve usability for people who > don't realise that the default is wrong for 99%+ of users. > > Peter Maydell (2): > hw/arm: Stop specifying integratorcp as the default board > vl.c: Improve message when no default machine is found > > hw/arm/integratorcp.c | 1 - > vl.c | 3 ++- > 2 files changed, 2 insertions(+), 2 deletions(-) > series Reviewed-by: Paolo Bonzini