From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 05/34] xen/xsm: flask: Remove unused function avc_sidcmp Date: Wed, 26 Mar 2014 11:57:37 +0000 Message-ID: <5332CEC10200007800002493@nat28.tlf.novell.com> References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> <1395766541-23979-6-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WSmmK-0006Vx-LH for xen-devel@lists.xenproject.org; Wed, 26 Mar 2014 12:17:56 +0000 In-Reply-To: <1395766541-23979-6-git-send-email-julien.grall@linaro.org> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, Daniel De Graaf , stefano.stabellini@citrix.com, ian.campbell@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org >>> On 25.03.14 at 17:55, wrote: > Fix compilation with Clang 3.5: > > avc.c:657:19: error: unused function 'avc_sidcmp' [-Werror,-Wunused-function] > static inline int avc_sidcmp(u32 x, u32 y) Despite Daniel having acked this already, this seems conceptually wrong to me: static inline functions are quite frequently unused (and I assume the compiler warns about them only if they're not in a header file), and hence the compiler shouldn't be warning about them in the first place. Jan