From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH 30/34] xen: Add missing includes on
 different files
Date: Wed, 26 Mar 2014 17:41:52 +0000
Message-ID: <53331160.7060809@linaro.org>
References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org>
	<1395766541-23979-31-git-send-email-julien.grall@linaro.org>
	<5332DCD70200007800002512@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WSrpt-0000Si-3F
	for xen-devel@lists.xenproject.org; Wed, 26 Mar 2014 17:41:57 +0000
Received: by mail-bk0-f53.google.com with SMTP id r7so644225bkg.40
	for <xen-devel@lists.xenproject.org>;
	Wed, 26 Mar 2014 10:41:55 -0700 (PDT)
In-Reply-To: <5332DCD70200007800002512@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Daniel De Graaf <dgdegra@tycho.nsa.gov>, stefano.stabellini@citrix.com, ian.campbell@citrix.com, tim@xen.org
List-Id: xen-devel@lists.xenproject.org

On 03/26/2014 12:57 PM, Jan Beulich wrote:
>>>> On 25.03.14 at 17:55, <julien.grall@linaro.org> wrote:
>> --- a/xen/common/multicall.c
>> +++ b/xen/common/multicall.c
>> @@ -6,6 +6,9 @@
>>  #include <xen/types.h>
>>  #include <xen/lib.h>
>>  #include <xen/mm.h>
>> +#ifndef COMPAT
>> +#include <xen/hypercall.h>
>> +#endif
> =

> Is there anything wrong with adding this without the seemingly
> unmotivated #ifndef?

The prototype in hypercall.h return directly long, but the definition
returns ret_t (which is replaced by int if COMPAT is defined).

This will result to a compilation failure:

In file included from multicall.c:41:0:
../multicall.c:38:1: error: conflicting types for =91compat_multicall=92
In file included from ../multicall.c:9:0,
                 from multicall.c:41:

-- =

Julien Grall