From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT0WK-0007mq-Av for qemu-devel@nongnu.org; Wed, 26 Mar 2014 22:58:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WT0WG-0005Ty-9E for qemu-devel@nongnu.org; Wed, 26 Mar 2014 22:58:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT0WF-0005Tm-Px for qemu-devel@nongnu.org; Wed, 26 Mar 2014 22:58:16 -0400 Message-ID: <533393C1.90509@redhat.com> Date: Wed, 26 Mar 2014 20:58:09 -0600 From: Eric Blake MIME-Version: 1.0 References: <1395417673-17710-1-git-send-email-benoit.canet@irqsave.net> <1395417673-17710-3-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1395417673-17710-3-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="roCMegXn5aQw9RURatJKbBnLwn0wKwIrI" Subject: Re: [Qemu-devel] [PATCH 2/2] qapi: Create an include directive for use in the JSON description files. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: anthony@codemonkey.ws, Benoit Canet , armbru@redhat.com, wenchaoqemu@gmail.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --roCMegXn5aQw9RURatJKbBnLwn0wKwIrI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/21/2014 10:01 AM, Beno=C3=AEt Canet wrote: > The new directive in the form { 'include': 'path/to/file.json' } will t= rigger the > parsing of path/to/file.json. > The directive will be replaced by the result of the parsing. >=20 > This will allow for easy modularisation of qapi JSON descriptions files= =2E >=20 > The qapi commands now takes the input file path as first argument to ma= ke it > easier to detect include loops: stdin would not allow to do this. It would be better to split this into two patches - one that alters the framework to pass filenames and updates the testsuite to reflect the improved error messages in existing tests, and the second to add the new 'include' directive with the new tests. >=20 > Signed-off-by: Benoit Canet > --- > Makefile | 24 +++++------ > scripts/qapi-commands.py | 8 +++- > scripts/qapi-types.py | 8 +++- > scripts/qapi-visit.py | 8 +++- > scripts/qapi.py | 46 ++++++++++++++= +++----- > tests/Makefile | 16 ++++---- Missing a change to docs/qapi-code-gen.txt. New features require documentation. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --roCMegXn5aQw9RURatJKbBnLwn0wKwIrI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTM5PBAAoJEKeha0olJ0Nq6v0H/RZ0tGmMB/BNS6QU7JKUzHJk vW009zpUi9CXL0xNYVsC+LMCkeuKgqmJ8Uwj8/rHvu9AEFBQJ72p05rHwNm0d6B3 uRGs0/oC7+BHQxJe29MLuK0/b8cHOoBpXa+nQkGUmnMmkg3OmuLxPfW0ZTfpksFk C/s2X847K/2SZtjsOlVOWTCgQdrzQ0dHljM+MRGCIfAbU+JUEHvwyWGGxQEudVXc ITaerlmO44YkqfbxErjcM210/BU/Wg4VTK0vjI3A1br9JuPAbYAqKG1zuZHQdgBH CwBiV4kpDvhcC0pgjn5IGv48rVWu2UwoG42DVrpl722yQMC0yFz4YGrEdWju1Lk= =STzK -----END PGP SIGNATURE----- --roCMegXn5aQw9RURatJKbBnLwn0wKwIrI--