From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH 0/2] input/serio: Add a firmware_id sysfs attribute Date: Fri, 28 Mar 2014 09:29:50 +0100 Message-ID: <533532FE.2000304@redhat.com> References: <1395310330-3232-1-git-send-email-hdegoede@redhat.com> <20140320172159.GA27400@srcf.ucam.org> <20140328075655.GE22093@core.coreip.homeip.net> <53352EFB.8000309@redhat.com> <20140328081739.GG22093@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11844 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102AbaC1I3z (ORCPT ); Fri, 28 Mar 2014 04:29:55 -0400 In-Reply-To: <20140328081739.GG22093@core.coreip.homeip.net> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Dmitry Torokhov Cc: Matthew Garrett , Benjamin Tissoires , Peter Hutterer , platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org Hi, On 03/28/2014 09:17 AM, Dmitry Torokhov wrote: > On Fri, Mar 28, 2014 at 09:12:43AM +0100, Hans de Goede wrote: >> Hi, >> >> On 03/28/2014 08:56 AM, Dmitry Torokhov wrote: >>> On Thu, Mar 20, 2014 at 05:21:59PM +0000, Matthew Garrett wrote: >>>> On Thu, Mar 20, 2014 at 11:12:08AM +0100, Hans de Goede wrote: >>>> >>>>> Which in the end turns out to be much nicer too, since it gets rid of needing >>>>> a udev-helper too. After this much too long introduction I'll let the patches >>>>> speak for themselves. >>>> >>>> Yeah, I was coming to the conclusion that this was probably the best we >>>> could do. It's unfortunate that "id" is already in use - we'd be able to >>>> get away without any X server modifications otherwise. >>>> >>>> Long term we probably still want to tie serio devices to the ACPI >>>> devices in case the vendor provides power management calls there, but we >>>> can leave that until there's an actual example. >>> >>> I am still unsure if we shoudl be adding these new IDs to serio core... >>> Can't the X driver take a peek at ACPI devices on it's own? >> >> The problem is there is no way for userspace to know which /sys/devices/pnp0/00:xx >> device is the serio bus host. > > Practically speaking you should not care - there is only one touchpad in > Lenovos. So are you suggesting we simply go over all /sys/devices/pnp0/00:xx devices looking for a pnp-id we're interested in ? I'm sorry but that is just a non-sense solution, which reminds me of the good old days of random poking io-ports to probe stuff. We're not blindly going to read every /sys/devices/pnp0/00:xx/id attribute on a system, assuming that if it contains a pnp-id we're interested in it happens to belong to the input device we're enumerating at that time. Regards, Hans