From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 3/7] arch, arm: let map_mmio_regions() take pfn as parameters Date: Fri, 28 Mar 2014 13:31:27 +0000 Message-ID: <533579AF.2000005@linaro.org> References: <1395712976-19454-1-git-send-email-avanzini.arianna@gmail.com> <1395712976-19454-4-git-send-email-avanzini.arianna@gmail.com> <53317C8F.5040404@linaro.org> <53357045.9020300@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53357045.9020300@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Arianna Avanzini Cc: julien.grall@citrix.com, paolo.valente@unimore.it, keir@xen.org, Stefano Stabellini , tim@xen.org, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, Ian.Campbell@eu.citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, viktor.kleinik@globallogic.com List-Id: xen-devel@lists.xenproject.org On 03/28/2014 12:51 PM, Arianna Avanzini wrote: > On 03/25/2014 01:54 PM, Julien Grall wrote: > Hello, Hi Arianna, >> On 03/25/2014 12:22 PM, Stefano Stabellini wrote: >>>> - return apply_p2m_changes(d, INSERT, start_gaddr, end_gaddr, >>>> - maddr, MATTR_DEV, p2m_mmio_direct); >>>> + return apply_p2m_changes(d, INSERT, >>>> + pfn_to_paddr(start_gfn), >>>> + pfn_to_paddr(end_gfn), >>>> + pfn_to_paddr(mfn), >>>> + MATTR_DEV, p2m_mmio_direct); >>>> } >>> >>> This doesn't make any sense. Shouldn't you modify apply_p2m_changes to >>> take pfns as parameters too? >> >> If so, I think it should be a separate patch. Her change makes sense >> with the current interface. >> > > Thank you both for the feedback. Sorry if I bother you with a question, would > you like a separate patch to modify also apply_p2m_changes() to take pfns as > parameters, or would you prefer to keep the current interface by now? As you want, I don't think this change is critical for now. Regards, -- Julien Grall