From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36690)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WTaTa-0004z5-Um
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 13:22:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WTaTS-0000OQ-4D
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 13:21:54 -0400
Received: from cantor2.suse.de ([195.135.220.15]:58410 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WTaTR-0000OL-To
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 13:21:46 -0400
Message-ID: <5335AFA7.9010306@suse.de>
Date: Fri, 28 Mar 2014 18:21:43 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <20140328105709.21018.88000.stgit@bahia.local>	<20140328105756.21018.57522.stgit@bahia.local>
	<20140328181326.22c0a6a5@bahia.local>
In-Reply-To: <20140328181326.22c0a6a5@bahia.local>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v6 6/8] virtio-scsi: use virtio wrappers to
 access headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, thuth@linux.vnet.ibm.com, mst@redhat.com, marc.zyngier@arm.com, rusty@rustcorp.com.au, agraf@suse.de, qemu-devel@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, anthony@codemonkey.ws

Am 28.03.2014 18:13, schrieb Greg Kurz:
> On Fri, 28 Mar 2014 11:57:56 +0100
> Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
>> @@ -519,8 +521,8 @@ static void virtio_scsi_push_event(VirtIOSCSI *s, =
SCSIDevice *dev,
>>
>>      evt =3D req->resp.event;
>>      memset(evt, 0, sizeof(VirtIOSCSIEvent));
>> -    evt->event =3D event;
>> -    evt->reason =3D reason;
>> +    evt->event =3D virtio_tswap32(event);
>> +    evt->reason =3D virtio_tswap32(reason);
>=20
> My bad again, it should be:
>=20
>  +    evt->event =3D virtio_tswap32(event, vdev);
>  +    evt->reason =3D virtio_tswap32(reason, vdev);

Pure bikeshedding, but wouldn't it make sense to have the vdev as first
argument?

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg