From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v4 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers Date: Wed, 31 May 2017 15:23:49 +0100 Message-ID: <53360973-098e-14fa-88e9-b0864822359a@nvidia.com> References: <1495452207-6129-1-git-send-email-vivek.gautam@codeaurora.org> <1495452207-6129-5-git-send-email-vivek.gautam@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1495452207-6129-5-git-send-email-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Content-Language: en-US Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vivek Gautam , p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thierry Reding List-Id: linux-tegra@vger.kernel.org On 22/05/17 12:23, Vivek Gautam wrote: > Make use of reset_control_array_*() set of APIs to manage > an array of reset controllers available with the device. > > Cc: Jon Hunter > Cc: Thierry Reding > Cc: Philipp Zabel > Signed-off-by: Vivek Gautam > --- > drivers/soc/tegra/pmc.c | 91 +++++++++++++++++-------------------------------- > 1 file changed, 31 insertions(+), 60 deletions(-) > > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c > index e233dd5dcab3..668f5d3d3635 100644 > --- a/drivers/soc/tegra/pmc.c > +++ b/drivers/soc/tegra/pmc.c > @@ -124,8 +124,8 @@ struct tegra_powergate { > unsigned int id; > struct clk **clks; > unsigned int num_clks; > - struct reset_control **resets; > - unsigned int num_resets; > + struct reset_control *reset; > + struct reset_control_array *resets; It's a shame we can't avoid this additional reset pointer, but maybe there is no good alternative for now. So ... Acked-by: Jon Hunter Tested-by: Jon Hunter Cheers Jon -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751154AbdEaOX6 (ORCPT ); Wed, 31 May 2017 10:23:58 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:18898 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965AbdEaOXz (ORCPT ); Wed, 31 May 2017 10:23:55 -0400 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Wed, 31 May 2017 07:23:54 -0700 Subject: Re: [PATCH v4 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers To: Vivek Gautam , , CC: , , , , , Thierry Reding References: <1495452207-6129-1-git-send-email-vivek.gautam@codeaurora.org> <1495452207-6129-5-git-send-email-vivek.gautam@codeaurora.org> From: Jon Hunter Message-ID: <53360973-098e-14fa-88e9-b0864822359a@nvidia.com> Date: Wed, 31 May 2017 15:23:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1495452207-6129-5-git-send-email-vivek.gautam@codeaurora.org> X-Originating-IP: [10.21.132.162] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/05/17 12:23, Vivek Gautam wrote: > Make use of reset_control_array_*() set of APIs to manage > an array of reset controllers available with the device. > > Cc: Jon Hunter > Cc: Thierry Reding > Cc: Philipp Zabel > Signed-off-by: Vivek Gautam > --- > drivers/soc/tegra/pmc.c | 91 +++++++++++++++++-------------------------------- > 1 file changed, 31 insertions(+), 60 deletions(-) > > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c > index e233dd5dcab3..668f5d3d3635 100644 > --- a/drivers/soc/tegra/pmc.c > +++ b/drivers/soc/tegra/pmc.c > @@ -124,8 +124,8 @@ struct tegra_powergate { > unsigned int id; > struct clk **clks; > unsigned int num_clks; > - struct reset_control **resets; > - unsigned int num_resets; > + struct reset_control *reset; > + struct reset_control_array *resets; It's a shame we can't avoid this additional reset pointer, but maybe there is no good alternative for now. So ... Acked-by: Jon Hunter Tested-by: Jon Hunter Cheers Jon -- nvpublic