From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84172C2D0BF for ; Mon, 16 Dec 2019 10:18:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63FB6206D3 for ; Mon, 16 Dec 2019 10:18:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63FB6206D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD20C6E47B; Mon, 16 Dec 2019 10:18:34 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C35B6E47B; Mon, 16 Dec 2019 10:18:33 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Dec 2019 02:18:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,321,1571727600"; d="scan'208";a="221470459" Received: from gackerm1-mobl1.ger.corp.intel.com (HELO [10.252.49.201]) ([10.252.49.201]) by fmsmga001.fm.intel.com with ESMTP; 16 Dec 2019 02:18:31 -0800 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20191216093433.2517697-1-chris@chris-wilson.co.uk> From: Lionel Landwerlin Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ Message-ID: <5336ba4a-e8ac-84b8-0ba9-6b364e5c4ca0@intel.com> Date: Mon, 16 Dec 2019 12:18:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20191216093433.2517697-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/perf: Skip OA testing on systems too old X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 16/12/2019 11:34, Chris Wilson wrote: > Don't flat out fail if the system doesn't support OA, just skip. > > Closes: https://gitlab.freedesktop.org/drm/intel/issues/834 > Signed-off-by: Chris Wilson > --- > tests/perf.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tests/perf.c b/tests/perf.c > index f5dd6051e..12f552743 100644 > --- a/tests/perf.c > +++ b/tests/perf.c > @@ -884,11 +884,9 @@ init_sys_info(void) > const char *test_set_uuid = NULL; > char buf[256]; > > - igt_assert_neq(devid, 0); > - > timestamp_frequency = get_cs_timestamp_frequency(); > igt_debug("timestamp_frequency = %lu\n", timestamp_frequency); > - igt_assert_neq(timestamp_frequency, 0); > + igt_require(timestamp_frequency); > > if (IS_HASWELL(devid)) { > /* We don't have a TestOa metric set for Haswell so use I guess I'm too young to know that some platforms don't even have a timestamp register... Reviewed-by: Lionel Landwerlin Thanks, -Lionel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20191216093433.2517697-1-chris@chris-wilson.co.uk> From: Lionel Landwerlin Message-ID: <5336ba4a-e8ac-84b8-0ba9-6b364e5c4ca0@intel.com> Date: Mon, 16 Dec 2019 12:18:30 +0200 MIME-Version: 1.0 In-Reply-To: <20191216093433.2517697-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t] i915/perf: Skip OA testing on systems too old List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: On 16/12/2019 11:34, Chris Wilson wrote: > Don't flat out fail if the system doesn't support OA, just skip. > > Closes: https://gitlab.freedesktop.org/drm/intel/issues/834 > Signed-off-by: Chris Wilson > --- > tests/perf.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tests/perf.c b/tests/perf.c > index f5dd6051e..12f552743 100644 > --- a/tests/perf.c > +++ b/tests/perf.c > @@ -884,11 +884,9 @@ init_sys_info(void) > const char *test_set_uuid = NULL; > char buf[256]; > > - igt_assert_neq(devid, 0); > - > timestamp_frequency = get_cs_timestamp_frequency(); > igt_debug("timestamp_frequency = %lu\n", timestamp_frequency); > - igt_assert_neq(timestamp_frequency, 0); > + igt_require(timestamp_frequency); > > if (IS_HASWELL(devid)) { > /* We don't have a TestOa metric set for Haswell so use I guess I'm too young to know that some platforms don't even have a timestamp register... Reviewed-by: Lionel Landwerlin Thanks, -Lionel _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev