From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Qiu, Michael" <michael.qiu@intel.com>
Subject: Re: [PATCH v2] ixgbe: Fix disable interrupt twice
Date: Mon, 1 Feb 2016 08:05:15 +0000
Message-ID: <533710CFB86FA344BFBF2D6802E6028622F28091@SHSMSX101.ccr.corp.intel.com>
References: <1454046700-20843-1-git-send-email-michael.qiu@intel.com>
 <1454047090-21274-1-git-send-email-michael.qiu@intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC0909034256DA@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id EC7348D35
 for <dev@dpdk.org>; Mon,  1 Feb 2016 09:05:18 +0100 (CET)
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/29/2016 4:07 PM, Lu, Wenzhuo wrote:=0A=
> Hi Michael,=0A=
>=0A=
>> -----Original Message-----=0A=
>> From: Qiu, Michael=0A=
>> Sent: Friday, January 29, 2016 1:58 PM=0A=
>> To: dev@dpdk.org=0A=
>> Cc: Zhou, Danny; Liu, Yong; Liang, Cunming; Lu, Wenzhuo; Qiu, Michael=0A=
>> Subject: [PATCH v2] ixgbe: Fix disable interrupt twice=0A=
>>=0A=
>> Currently, ixgbe vf and pf will disable interrupt twice in stop stage an=
d uninit=0A=
>> stage. It will cause an error:=0A=
>>=0A=
>>     testpmd> quit=0A=
>>=0A=
>>     Shutting down port 0...=0A=
>>     Stopping ports...=0A=
>>     Done=0A=
>>     Closing ports...=0A=
>>     EAL: Error disabling MSI-X interrupts for fd 26=0A=
>>     Done=0A=
>>=0A=
>> Becasue the interrupt already been disabled in stop stage.=0A=
>> Since it is enabled in init stage, better remove from stop stage.=0A=
> I'm afraid it=92s not a good idea to just remove the intr_disable from de=
v_stop.=0A=
> I think dev_stop have the chance to be used independently with dev_unint.=
 In this scenario, we still need intr_disable, right?=0A=
> Maybe what we need is some check before we disable the intr:)=0A=
=0A=
Yes, indeed we need some check in disable intr, but it need additional=0A=
fields in "struct rte_intr_handle",  and it's much saft to do so, but as=0A=
I check i40e/fm10k code, only ixgbe disable it in dev_stop().=0A=
=0A=
On other hand, if we remove it in dev_stop, any side effect? In ixgbe=0A=
start, it will always disable it first and then re-enable it, so it's safe.=
=0A=
=0A=
Thanks,=0A=
Michael=0A=
>=0A=
=0A=