From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Qiu, Michael" <michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] i40e: bug fix of compile error
Date: Tue, 2 Dec 2014 06:58:30 +0000
Message-ID: <533710CFB86FA344BFBF2D6802E60286C9BECF@SHSMSX101.ccr.corp.intel.com>
References: <1417419227-21465-1-git-send-email-helin.zhang@intel.com>
 <2036571.ijmOSAQnXA@xps13>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7CD380@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed;
 boundary="_002_533710CFB86FA344BFBF2D6802E60286C9BECFSHSMSX101ccrcorpi_"
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: "Zhang, Helin" <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Thomas Monjalon
 <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

--_002_533710CFB86FA344BFBF2D6802E60286C9BECFSHSMSX101ccrcorpi_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

On 12/2/2014 8:36 AM, Zhang, Helin wrote:=0A=
>=0A=
>> -----Original Message-----=0A=
>> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]=0A=
>> Sent: Monday, December 1, 2014 7:13 PM=0A=
>> To: Zhang, Helin=0A=
>> Cc: dev-VfR2kkLFssw@public.gmane.org=0A=
>> Subject: Re: [dpdk-dev] [PATCH] i40e: bug fix of compile error=0A=
>>=0A=
>> 2014-12-01 15:33, Helin Zhang:=0A=
>>> The compile error will occur as below when set=0A=
>> 'RTE_LIBRTE_I40E_16BYTE_RX_DESC=3Dy'.=0A=
>>> The changes is just to fix it.=0A=
>>>=0A=
>>> lib/librte_pmd_i40e/i40e_rxtx.c: In function i40e_rxd_build_fdir:=0A=
>>> lib/librte_pmd_i40e/i40e_rxtx.c:431:28: error: volatile union=0A=
>>> <anonymous> has no member named fd=0A=
>>> lib/librte_pmd_i40e/i40e_rxtx.c:427:19: error: unused variable flexbl=
=0A=
>>> [-Werror=3Dunused-variable]=0A=
>>> lib/librte_pmd_i40e/i40e_rxtx.c:427:11: error: unused variable flexbh=
=0A=
>>> [-Werror=3Dunused-variable]=0A=
>> It would be nice to reference the commit which introduced the error and =
explain=0A=
>> it a bit.=0A=
>>=0A=
>>> -			rte_le_to_cpu_32(rxdp->wb.qword3.hi_dword.flex_bytes_hi);=0A=
>>> +			rte_le_to_cpu_32(=0A=
>>> +			rxdp->wb.qword3.hi_dword.flex_bytes_hi);=0A=
>> [...]=0A=
>>> -			rte_le_to_cpu_32(rxdp->wb.qword3.lo_dword.flex_bytes_lo);=0A=
>>> +			rte_le_to_cpu_32(=0A=
>>> +			rxdp->wb.qword3.lo_dword.flex_bytes_lo);=0A=
>> Why are you wrapping these lines (with wrong indentation)?=0A=
>> It makes the fix confuse.=0A=
> Sorry, it is a code style fix, as the length of the line should not be mo=
re than 80.=0A=
> Do I need to split the patch or add more commit logs?=0A=
=0A=
I think this coding style fix is not good enough,=0A=
=0A=
		mb->hash.fdir.hi =3D rte_le_to_cpu_32(rxdp->wb.qword3=0A=
						    .hi_dword.fd_id);=0A=
=0A=
This would be better :)=0A=
=0A=
See the attached diff file, so sorry I indeed do not know how to add=0A=
diff file in the email(except git send-email), So I just attached it.=0A=
=0A=
>=0A=
>> --=0A=
>> Thomas=0A=
> Regards,=0A=
> Helin=0A=
>=0A=
=0A=

--_002_533710CFB86FA344BFBF2D6802E60286C9BECFSHSMSX101ccrcorpi_
Content-Type: text/plain; name="diff_code_style_fix"
Content-Description: diff_code_style_fix
Content-Disposition: attachment; filename="diff_code_style_fix"; size=1471;
	creation-date="Tue, 02 Dec 2014 06:58:30 GMT";
	modification-date="Tue, 02 Dec 2014 06:58:30 GMT"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2xpYi9saWJydGVfcG1kX2k0MGUvaTQwZV9yeHR4LmMgYi9saWIvbGlicnRl
X3BtZF9pNDBlL2k0MGVfcnh0eC5jCmluZGV4IDJkMmVmMDQuLmUwMjY0ZmMgMTAwNjQ0Ci0tLSBh
L2xpYi9saWJydGVfcG1kX2k0MGUvaTQwZV9yeHR4LmMKKysrIGIvbGliL2xpYnJ0ZV9wbWRfaTQw
ZS9pNDBlX3J4dHguYwpAQCAtNDI3LDggKzQyNyw3IEBAIGk0MGVfcnhkX2J1aWxkX2ZkaXIodm9s
YXRpbGUgdW5pb24gaTQwZV9yeF9kZXNjICpyeGRwLCBzdHJ1Y3QgcnRlX21idWYgKm1iKQogCXVp
bnQxNl90IGZsZXhiaCwgZmxleGJsOwogCiAjaWZkZWYgUlRFX0xJQlJURV9JNDBFXzE2QllURV9S
WF9ERVNDCi0JbWItPmhhc2guZmRpci5oaSA9Ci0JCXJ0ZV9sZV90b19jcHVfMzIocnhkcC0+d2Iu
cXdvcmQwLmhpX2R3b3JkLmZkKTsKKwltYi0+aGFzaC5mZGlyLmhpID0gcnRlX2xlX3RvX2NwdV8z
MihyeGRwLT53Yi5xd29yZDAuaGlfZHdvcmQuZmQpOwogCWZsYWdzIHw9IFBLVF9SWF9GRElSX0lE
OwogI2Vsc2UKIAlmbGV4YmggPSAocnRlX2xlX3RvX2NwdV8zMihyeGRwLT53Yi5xd29yZDIuZXh0
X3N0YXR1cykgPj4KQEAgLTQ0MCwxNyArNDM5LDE3IEBAIGk0MGVfcnhkX2J1aWxkX2ZkaXIodm9s
YXRpbGUgdW5pb24gaTQwZV9yeF9kZXNjICpyeGRwLCBzdHJ1Y3QgcnRlX21idWYgKm1iKQogCiAK
IAlpZiAoZmxleGJoID09IEk0MEVfUlhfREVTQ19FWFRfU1RBVFVTX0ZMRVhCSF9GRF9JRCkgewot
CQltYi0+aGFzaC5mZGlyLmhpID0KLQkJCXJ0ZV9sZV90b19jcHVfMzIocnhkcC0+d2IucXdvcmQz
LmhpX2R3b3JkLmZkX2lkKTsKKwkJbWItPmhhc2guZmRpci5oaSA9IHJ0ZV9sZV90b19jcHVfMzIo
cnhkcC0+d2IucXdvcmQzCisJCQkJCQkgICAgLmhpX2R3b3JkLmZkX2lkKTsKIAkJZmxhZ3MgfD0g
UEtUX1JYX0ZESVJfSUQ7CiAJfSBlbHNlIGlmIChmbGV4YmggPT0gSTQwRV9SWF9ERVNDX0VYVF9T
VEFUVVNfRkxFWEJIX0ZMRVgpIHsKLQkJbWItPmhhc2guZmRpci5oaSA9Ci0JCQlydGVfbGVfdG9f
Y3B1XzMyKHJ4ZHAtPndiLnF3b3JkMy5oaV9kd29yZC5mbGV4X2J5dGVzX2hpKTsKKwkJbWItPmhh
c2guZmRpci5oaSA9IHJ0ZV9sZV90b19jcHVfMzIocnhkcC0+d2IucXdvcmQzCisJCQkJCQkgICAg
LmhpX2R3b3JkLmZsZXhfYnl0ZXNfaGkpOwogCQlmbGFncyB8PSBQS1RfUlhfRkRJUl9GTFg7CiAJ
fQogCWlmIChmbGV4YmwgPT0gSTQwRV9SWF9ERVNDX0VYVF9TVEFUVVNfRkxFWEJMX0ZMRVgpIHsK
LQkJbWItPmhhc2guZmRpci5sbyA9Ci0JCQlydGVfbGVfdG9fY3B1XzMyKHJ4ZHAtPndiLnF3b3Jk
My5sb19kd29yZC5mbGV4X2J5dGVzX2xvKTsKKwkJbWItPmhhc2guZmRpci5sbyA9IHJ0ZV9sZV90
b19jcHVfMzIocnhkcC0+d2IucXdvcmQzCisJCQkJCQkgICAgLmxvX2R3b3JkLmZsZXhfYnl0ZXNf
bG8pOwogCQlmbGFncyB8PSBQS1RfUlhfRkRJUl9GTFg7CiAJfQogI2VuZGlmCg==

--_002_533710CFB86FA344BFBF2D6802E60286C9BECFSHSMSX101ccrcorpi_--