From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
SCSI development list <linux-scsi@vger.kernel.org>
Cc: USB list <linux-usb@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 2/3] [SCSI] Fix spurious request sense in error handling
Date: Mon, 31 Mar 2014 08:59:30 +0200 [thread overview]
Message-ID: <53391252.8010909@suse.de> (raw)
In-Reply-To: <1396029017.15365.32.camel@dabdike>
On 03/28/2014 06:50 PM, James Bottomley wrote:
> We unconditionally execute scsi_eh_get_sense() to make sure all failed
> commands that should have sense attached, do. However, the routine forgets
> that some commands, because of the way they fail, will not have any sense code
> ... we should not bother them with a REQUEST_SENSE command. Fix this by
> testing to see if we actually got a CHECK_CONDITION return and skip asking for
> sense if we don't.
>
> Tested-by: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Acked-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-31 6:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 17:47 [PATCH 0/3] Fix USB deadlock caused by SCSI error handling James Bottomley
2014-03-28 17:49 ` [PATCH 1/3] [SCSI] Fix abort state memory problem James Bottomley
2014-03-31 6:58 ` Hannes Reinecke
2014-03-31 13:06 ` Alan Stern
2014-03-28 17:50 ` [PATCH 2/3] [SCSI] Fix spurious request sense in error handling James Bottomley
2014-03-31 6:59 ` Hannes Reinecke [this message]
2014-03-28 17:51 ` [PATCH 3/3] [SCSI] Fix command result state propagation James Bottomley
2014-03-31 7:00 ` Hannes Reinecke
2014-03-28 19:29 ` [PATCH 0/3] Fix USB deadlock caused by SCSI error handling Alan Stern
2014-03-31 7:22 ` Hannes Reinecke
2014-03-31 13:33 ` Alan Stern
2014-03-31 14:37 ` Hannes Reinecke
[not found] ` <53397DAE.9010801-l3A5Bk7waGM@public.gmane.org>
2014-03-31 15:03 ` James Bottomley
2014-03-31 22:41 ` Alan Stern
[not found] ` <1396278224.3152.26.camel-sFMDBYUN5F8GjUHQrlYNx2Wm91YjaHnnhRte9Li2A+AAvxtiuMwx3w@public.gmane.org>
2014-04-01 6:14 ` Hannes Reinecke
2014-03-31 22:29 ` Alan Stern
2014-04-01 15:37 ` Hannes Reinecke
[not found] ` <533ADD26.1030300-l3A5Bk7waGM@public.gmane.org>
2014-04-01 21:28 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1404011718350.7652-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2014-04-02 6:03 ` Hannes Reinecke
2014-04-07 15:26 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1404071125220.20747-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2014-04-09 17:42 ` Hannes Reinecke
[not found] ` <53458680.4090500-l3A5Bk7waGM@public.gmane.org>
2014-04-09 18:02 ` Alan Stern
2014-04-10 10:58 ` Andreas Reis
2014-04-10 11:37 ` Hannes Reinecke
2014-04-10 12:26 ` Andreas Reis
2014-04-10 12:29 ` Hannes Reinecke
2014-04-10 15:31 ` Alan Stern
2014-04-10 17:52 ` Hannes Reinecke
[not found] ` <5346DA43.4010603-l3A5Bk7waGM@public.gmane.org>
2014-04-10 20:36 ` James Bottomley
2014-04-11 5:52 ` Hannes Reinecke
[not found] ` <53468297.1040909-l3A5Bk7waGM@public.gmane.org>
2014-04-11 19:08 ` Andreas Reis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53391252.8010909@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.