From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50257)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1WUfdp-0002Qa-Qw
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 13:05:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1WUfdk-0007vK-OL
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 13:04:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42845)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1WUfdk-0007vF-FL
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 13:04:52 -0400
Message-ID: <5339A032.7080803@redhat.com>
Date: Mon, 31 Mar 2014 13:04:50 -0400
From: Cole Robinson <crobinso@redhat.com>
MIME-Version: 1.0
References: <53387E35.3010909@redhat.com> <20140330204837.GA2903@redhat.com>
In-Reply-To: <20140330204837.GA2903@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] 2.0 regression: loadvm assertion with ehci + tablet
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>

On 03/30/2014 04:48 PM, Michael S. Tsirkin wrote:
> On Sun, Mar 30, 2014 at 04:27:33PM -0400, Cole Robinson wrote:
>> With git master, loadvm hits an assert failure if using ehci and usb t=
ablet.
>> Steps to reproduce:
>>
>> $ qemu-img create -f qcow2 foo.qcow2 10G
>> $ ./x86_64-softmmu/qemu-system-x86_64 \
>>   -enable-kvm -m 4096 \
>>   -device ich9-usb-ehci1,id=3Dusb,bus=3Dpci.0,addr=3D0x5.0x7 \
>>   -device
>> ich9-usb-uhci1,masterbus=3Dusb.0,firstport=3D0,bus=3Dpci.0,multifuncti=
on=3Don,addr=3D0x5 \
>>   -device ich9-usb-uhci2,masterbus=3Dusb.0,firstport=3D2,bus=3Dpci.0,a=
ddr=3D0x5.0x1 \
>>   -device ich9-usb-uhci3,masterbus=3Dusb.0,firstport=3D4,bus=3Dpci.0,a=
ddr=3D0x5.0x2 \
>>   -device usb-tablet,id=3Dinput0 \
>>   -hda foo.qcow2 \
>>   -cdrom Fedora-20-x86_64-Live-Desktop.iso \
>>   -boot d -monitor stdio
>>
>> <wait until guest boot to 'welcome to fedora' window>
>> (qemu) savevm foo
>> (qemu) loadvm foo
>> qemu-system-x86_64: hw/pci/pci.c:250: pcibus_reset: Assertion
>> `bus->irq_count[i] =3D=3D 0' failed.
>>
>> The relevant backtrace bits for the assertion:
>>
>> #4  0x00007f8f7241971e in pcibus_reset (qbus=3D0x7f8f74082fd0)
>>     at hw/pci/pci.c:250
>> #5  0x00007f8f723bd36d in qbus_reset_one (bus=3D0x7f8f74082fd0,
>>     opaque=3D<optimized out>) at hw/core/qdev.c:249
>> #6  0x00007f8f723bec88 in qdev_walk_children (dev=3D0x7f8f73efb320,
>>     pre_devfn=3D0x0, pre_busfn=3D0x0, post_devfn=3D0x7f8f723bf4f0 <qde=
v_reset_one>,
>>     post_busfn=3D0x7f8f723bd320 <qbus_reset_one>, opaque=3D0x0)
>>     at hw/core/qdev.c:403
>> #7  0x00007f8f723bedb8 in qbus_walk_children (bus=3D0x7f8f740706e0,
>>     pre_devfn=3D0x0, pre_busfn=3D0x0, post_devfn=3D0x7f8f723bf4f0 <qde=
v_reset_one>,
>>     post_busfn=3D0x7f8f723bd320 <qbus_reset_one>, opaque=3D0x0)
>>     at hw/core/qdev.c:369
>> #8  0x00007f8f724f5c5d in qemu_devices_reset () at vl.c:1867
>> #9  qemu_system_reset (report=3Dreport@entry=3Dfalse) at vl.c:1880
>> #10 0x00007f8f7256dba2 in load_vmstate (name=3Dname@entry=3D0x7f8f7417=
a160 "foo")
>>     at /home/crobinso/src/qemu/savevm.c:1098
>>
>> The 'cause' is this:
>>
>> #0  ehci_detach (port=3D0x555556436968) at hw/usb/hcd-ehci.c:810
>> #1  0x0000555555727b5e in usb_detach (port=3Dport@entry=3D0x5555564369=
68)
>>     at hw/usb/core.c:49
>> #2  0x0000555555736bf3 in ehci_reset (opaque=3D0x5555564364d8)
>>     at hw/usb/hcd-ehci.c:941
>> #3  0x00005555557e1fcd in qemu_devices_reset () at vl.c:1867
>> #4  qemu_system_reset (report=3Dreport@entry=3Dfalse) at vl.c:1880
>> #5  0x0000555555859f12 in load_vmstate (name=3Dname@entry=3D0x55555645=
8210 "foo")
>>     at /home/crobinso/src/qemu/savevm.c:1098
>>
>> ehci_reset calls usb_detach which sets pcibus->irq_count[3] =3D 1. pci=
bus_reset
>> runs and hits the assertion. But I don't understand this stuff enough =
to
>> determine what's actually wrong here :)
>>
>> I bisected the issue to:
>>
>> commit 31b030d4abc5bea89c2b33b39d3b302836f6b6ee
>> Author: Andreas F=E4rber <afaerber@suse.de>
>> Date:   Wed Sep 4 01:29:02 2013 +0200
>>
>>     cputlb: Change tlb_flush_page() argument to CPUState
>>
>>     Signed-off-by: Andreas F=E4rber <afaerber@suse.de>
>>
>> ...and then I double checked it since that sounds unrelated. Same resu=
lt.
>>
>> Thanks,
>> Cole
>=20
> Looking for related stuff in pci, try this one:
>     qdev: switch reset to post-order
>=20

Not exactly sure what you mean, but I tried reverting that on master, sti=
ll
hit the same issue.

- Cole