Re: [Qemu-devel] [PATCH for-2.0 2/7] smbus: return -1 if nothing found at the given address

From: "Andreas Färber" <afaerber@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH for-2.0 2/7] smbus: return -1 if nothing found at the given address
Date: Mon, 31 Mar 2014 23:29:50 +0200	[thread overview]
Message-ID: <5339DE4E.3010900@suse.de> (raw)
In-Reply-To: <1396283195-6819-3-git-send-email-pbonzini@redhat.com>

Am 31.03.2014 18:26, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/i2c/smbus.c         | 62 +++++++++++++++++++++++++++++++++++---------------
>  include/hw/i2c/smbus.h | 12 +++++-----
>  2 files changed, 50 insertions(+), 24 deletions(-)
> 
> diff --git a/hw/i2c/smbus.c b/hw/i2c/smbus.c
> index 190f08e..6e27ae8 100644
> --- a/hw/i2c/smbus.c
> +++ b/hw/i2c/smbus.c
> @@ -208,34 +208,44 @@ static int smbus_device_init(I2CSlave *i2c)
>  }
>  
>  /* Master device commands.  */
> -void smbus_quick_command(I2CBus *bus, uint8_t addr, int read)
> +int smbus_quick_command(I2CBus *bus, uint8_t addr, int read)
>  {
> -    i2c_start_transfer(bus, addr, read);
> +    if (i2c_start_transfer(bus, addr, read)) {

For anyone else who wondered about this condition: i2c_start_transfer()
returns 1 if slave device is not found and 0 on success, so no normal
return codes interfering here.

> +        return -1;
> +    }
>      i2c_end_transfer(bus);
> +    return 0;
>  }
[snip]

Reviewed-by: Andreas Färber <afaerber@suse.de>

Might have mentioned also doing some adjacent Coding Style cleanups.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg