From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 26/34] xen/arm: traps: Drop dump_guest_s1_walk Date: Tue, 01 Apr 2014 17:59:31 +0100 Message-ID: <533AF073.1040709@linaro.org> References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> <1395766541-23979-27-git-send-email-julien.grall@linaro.org> <1395940176.22909.221.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WV22B-0004Fi-Qi for xen-devel@lists.xenproject.org; Tue, 01 Apr 2014 16:59:36 +0000 Received: by mail-we0-f172.google.com with SMTP id t61so6680371wes.3 for ; Tue, 01 Apr 2014 09:59:34 -0700 (PDT) In-Reply-To: <1395940176.22909.221.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 03/27/2014 05:09 PM, Ian Campbell wrote: > On Tue, 2014-03-25 at 16:55 +0000, Julien Grall wrote: >> This function is not used neither export. > > I have used it when debugging stuff, where it is very useful. I was not sure if anyone was using it. I can export it in p2m.h. I'm also thinking to move this function in p2m.c (which is a best place for this function). What do you think? > Should it not be called from one of the dump_vcpu_state in response to > an exception which implies a guest translation fault? > No, we inject directly an exception to the guest since few months. So we don't have to print the p2m. Regards, -- Julien Grall