From: Alexander Holler <holler@ahsoftware.de>
To: Michal Marek <mmarek@suse.cz>, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Levente Kurusa <levex@linux.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2 v3] initramfs: print error and shell out for unsupported content
Date: Tue, 01 Apr 2014 19:52:03 +0200 [thread overview]
Message-ID: <533AFCC3.3030504@ahsoftware.de> (raw)
In-Reply-To: <533AAFCB.7060409@suse.cz>
Am 01.04.2014 14:23, schrieb Michal Marek:
> On 2014-04-01 13:23, Alexander Holler wrote:
>> But as I already said, trying to use arbitrary filenames in a Makefile
>> doesn't really work. There are still other problems, e.g. filenames with
>> a / (directory separator), *, or some of the special make variables like $<.
>>
>> So the really working solution would be to get rid of that generated
>> (and hidden) include. Modifying gen_init_cpio.c to browse and collect
>> all filenames and types itself doesn't look like much work (an evening
>> should be enough).
>>
>> The drawback is that such a solution would build the initramfs every
>> time make is called (while CONFIG_INITRAMFS_SOURCE points to a
>> directory), but I think that time is negligible.
>
> Well, the cpio is embedded in the kernel image, so a rebuild of the cpio
> means a relink of the kernel. One option would be to implement the
> timestamp checking in gen_init_cpio.c, but I'm not sure if that's worth it.
I can't answer that too, but if someone spends the time implement the
directory traversing and collecting stats, it would just be one stat
more (to get the timestamp of an maybe already built cpio archive).
But I'm fine with just avoiding the most common problems (in my case
colons and spaces). And the little patch which makes sure that make
clean, distclean or mrproper will work always, avoids the need to search
how to fix the problem (deleting that hidden include) once a broken
include was generated.
Regards,
Alexander Holler
next prev parent reply other threads:[~2014-04-01 17:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 21:35 [PATCH] initramfs: print error and shell out for unsupported content Alexander Holler
2014-03-20 21:43 ` Levente Kurusa
2014-03-20 22:00 ` [PATCH v2] " Alexander Holler
2014-03-20 22:25 ` Alexander Holler
2014-03-21 21:03 ` Andrew Morton
2014-03-21 22:49 ` Alexander Holler
2014-03-21 22:55 ` Andrew Morton
2014-03-21 23:07 ` Alexander Holler
2014-03-22 9:53 ` Alexander Holler
2014-03-22 12:29 ` [PATCH 1/2] initramfs: don't include filenames from the initramfs for make goals (dist)clean Alexander Holler
2014-03-22 12:29 ` [PATCH 2/2 v3] initramfs: print error and shell out for unsupported content Alexander Holler
2014-03-22 18:22 ` Alexander Holler
2014-03-31 20:31 ` Michal Marek
2014-04-01 11:23 ` Alexander Holler
2014-04-01 12:23 ` Michal Marek
2014-04-01 17:52 ` Alexander Holler [this message]
2014-10-19 7:18 ` [PATCH 1/2 v4] initramfs: don't include filenames from the initramfs for make goals (dist)clean Alexander Holler
2014-10-19 7:18 ` [PATCH 2/2 v4] initramfs: print error and shell out for unsupported content Alexander Holler
2014-03-26 21:16 ` [PATCH v2] " Alexander Holler
2014-03-26 21:38 ` Levente Kurusa
2014-03-26 21:55 ` Alexander Holler
2014-03-26 22:37 ` Alexander Holler
2014-03-27 8:25 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533AFCC3.3030504@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=akpm@linux-foundation.org \
--cc=levex@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.