From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 04/15] xen/arm: move gic definitions to seperate file Date: Fri, 04 Apr 2014 16:37:46 +0100 Message-ID: <533ED1CA.5070205@linaro.org> References: <1396612593-443-1-git-send-email-vijay.kilari@gmail.com> <1396612593-443-5-git-send-email-vijay.kilari@gmail.com> <533EB35F.3000703@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Vijay Kilari Cc: Ian Campbell , Stefano Stabellini , Prasun Kapoor , Vijaya Kumar K , xen-devel@lists.xen.org, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 04/04/2014 04:29 PM, Vijay Kilari wrote: > On Fri, Apr 4, 2014 at 6:57 PM, Julien Grall wrote: >> Hi Vijaya, >> >> Thank you for the patch. >> >> On 04/04/2014 12:56 PM, vijay.kilari@gmail.com wrote: >>> diff --git a/xen/include/asm-arm/gic_v2_defs.h b/xen/include/asm-arm/gic_v2_defs.h >>> new file mode 100644 >>> index 0000000..f9ff885 >>> --- /dev/null >>> +++ b/xen/include/asm-arm/gic_v2_defs.h >>> @@ -0,0 +1,139 @@ >>> +/* >>> + * ARM Generic Interrupt Controller support v2 >>> + * >>> + * Vijaya Kumar K >>> + * Copyright (c) 2014 Cavium Inc. >> >> I'm not very familiar with copyright in general... but as this is code >> movement, should not you keep the copyright of Tim? >> > I am also not aware it. I kept as it in V1. You have asked me to change it > so I did. Anyways, I will put copyright of Tim Hrm, I read my mail and I didn't ask to modify the copyright... by guard I meant include guard: #ifndef __ASM_ARM_GIC_V2_DEFS_H__ #define __ASM_ARM_GIC_V2_DEFS_H__ your content #endif /* __ASM_ARM_GIC_V2_DEFS_H__ Without this the header is not protected against multiple inclusion. Regards, -- Julien Grall