From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2 15/15] xen/arm: update GIC dt node with
	GIC v3 information
Date: Fri, 04 Apr 2014 17:00:36 +0100
Message-ID: <533ED724.1070001@linaro.org>
References: <1396612593-443-1-git-send-email-vijay.kilari@gmail.com>
	<1396612593-443-16-git-send-email-vijay.kilari@gmail.com>
	<533EC014.4030500@linaro.org>
	<CALicx6v9us8bqKME4MVjQh876u6tUZB8DcHzxYgzQ7+eS6g0Fg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CALicx6v9us8bqKME4MVjQh876u6tUZB8DcHzxYgzQ7+eS6g0Fg@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vijay Kilari <vijay.kilari@gmail.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, xen-devel@lists.xen.org, Stefano Stabellini <stefano.stabellini@citrix.com>
List-Id: xen-devel@lists.xenproject.org

Hello Vijaya,

On 04/04/2014 04:45 PM, Vijay Kilari wrote:
> On Fri, Apr 4, 2014 at 7:52 PM, Julien Grall <julien.grall@linaro.org> wrote:
>> On 04/04/2014 12:56 PM, vijay.kilari@gmail.com wrote:
>>> +    if ( hw_type == GIC_VERSION_V3 )
>>> +    {
>>> +        res = dt_property_read_u32(gic, "redistributor-stride", &rd_stride);
>>> +        if ( !res )
>>> +            rd_stride = 0;
>>> +    }
>>
>>
>> You have skipped some of my remarks on V1. I would definitely prefer to
>> have a callback in your {v,}GIC structure which add the specific GIC
>> properties following the version supported by DOM0.
>>
> Yes, I recognized your comment. My understanding is that while
> creating this gic node for
> dom0, we should follow the order in creating cells.
> Also, the cells are allocated here and these should be passed to gic
> driver to fill it.
> So looks ugly.

I don't understand the issue with the order and the allocation...

You have bunch of code in if (hw_type == GICV3) than can be easily move
to the GIC driver.

You could have something like:

fdt_set_property(fdt, "mycommonprop1",..)
fdt_set_property(fdt, "mycommonprop2",..)
gic_node_specific_properties();
fdt_end();

> I prefer completely move this code to gic.c and from gic.c based on
> registered callback, let gic-{v2/v3}.c manage version specific dt cells update.
> Is this OK?

What do you mean?

Regards,

-- 
Julien Grall