From: Prabhakar Kushwaha <prabhakar@freescale.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Varun Sethi <Varun.Sethi@freescale.com>,
Poonam Aggrwal <poonam.aggrwal@freescale.com>,
linuxppc-dev@lists.ozlabs.org,
Priyanka Jain <Priyanka.Jain@freescale.com>
Subject: Re: [1/2, v9] powerpc/mpc85xx:Add initial device tree support of T104x
Date: Sun, 6 Apr 2014 18:48:15 +0530 [thread overview]
Message-ID: <53415417.3010802@freescale.com> (raw)
In-Reply-To: <20140319223334.GA28875@home.buserror.net>
On 3/20/2014 4:03 AM, Scott Wood wrote:
> On Sat, Jan 25, 2014 at 05:10:59PM +0530, Prabhakar Kushwaha wrote:
>> + corenet-cf@18000 {
>> + compatible = "fsl,corenet-cf";
>> + reg = <0x18000 0x1000>;
>> + interrupts = <16 2 1 31>;
>> + fsl,ccf-num-csdids = <32>;
>> + fsl,ccf-num-snoopids = <32>;
>> + };
> I know this isn't a new problem, but this needs a binding -- and a
> different compatible from p4080-era CCF. AFAICT it's a completely
> different programming model, and even the block version registers weren't
> present in the original version.
No binding present for corenet-cf looks like new binding needs to be
sent with possible compatabile.
>> +/include/ "qoriq-mpic.dtsi"
>> +
>> + guts: global-utilities@e0000 {
>> + compatible = "fsl,t1040-device-config", "fsl,qoriq-device-config-2.0";
>> + reg = <0xe0000 0xe00>;
>> + fsl,has-rstcr;
>> + fsl,liodn-bits = <12>;
>> + };
>> +
>> + clockgen: global-utilities@e1000 {
>> + compatible = "fsl,t1040-clockgen", "fsl,qoriq-clockgen-2.0",
>> + "fixed-clock";
>> + ranges = <0x0 0xe1000 0x1000>;
>> + clock-frequency = <100000000>;
> Why is clock-frequency hardcoded here rather than supplied by U-Boot?
> Especially since this is an SoC file, not a board file.
Your are correct.
Means, clock-frequency should be added to clockgen in board device tree ??
>> + reg = <0xe1000 0x1000>;
>> + clock-output-names = "sysclk";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
> clock-output-names and fixed-clock doesn't belong on this node.
Yes, clock-output-names and fixed-clock should be present in sysclk node.
>
>> +
>> + sysclk: sysclk {
>> + #clock-cells = <0>;
>> + compatible = "fsl,qoriq-sysclk-2.0";
>> + clock-output-names = "sysclk";
>> + };
>> +
>> +
>> + pll0: pll0@800 {
>> + #clock-cells = <1>;
>> + reg = <0x800 4>;
>> + compatible = "fsl,qoriq-core-pll-2.0";
>> + clocks = <&clockgen>;
>> + clock-output-names = "pll0", "pll0-div2", "pll0-div4";
>> + };
>> +
>> + pll1: pll1@820 {
>> + #clock-cells = <1>;
>> + reg = <0x820 4>;
>> + compatible = "fsl,qoriq-core-pll-2.0";
>> + clocks = <&clockgen>;
>> + clock-output-names = "pll1", "pll1-div2", "pll1-div4";
>> + };
> clocks should point to sysclk.
got it!!
>
>> + display@180000 {
>> + compatible = "fsl,t1040-diu", "fsl,diu";
>> + reg = <0x180000 1000>;
>> + interrupts = <74 2 0 0>;
>> + };
>> +
>> +/include/ "qoriq-sata2-0.dtsi"
>> +sata@220000 {
>> + fsl,iommu-parent = <&pamu0>;
>> + fsl,liodn-reg = <&guts 0x550>; /* SATA1LIODNR */
>> +};
>> +/include/ "qoriq-sata2-1.dtsi"
>> +sata@221000 {
>> + fsl,iommu-parent = <&pamu0>;
>> + fsl,liodn-reg = <&guts 0x554>; /* SATA2LIODNR */
>> +};
>> +/include/ "qoriq-sec5.0-0.dtsi"
>> +};
> Whitespace
>
>
i did not find this whitespace :(
Regards,
Prabhakar
next prev parent reply other threads:[~2014-04-06 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 11:40 [PATCH 1/2][v9] powerpc/mpc85xx:Add initial device tree support of T104x Prabhakar Kushwaha
2014-03-19 22:33 ` [1/2, v9] " Scott Wood
2014-04-06 13:18 ` Prabhakar Kushwaha [this message]
2014-04-07 18:22 ` [1/2,v9] " Scott Wood
2014-04-09 0:08 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53415417.3010802@freescale.com \
--to=prabhakar@freescale.com \
--cc=Priyanka.Jain@freescale.com \
--cc=Varun.Sethi@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=poonam.aggrwal@freescale.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.