All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cpts: Fix missing includes
@ 2014-04-06 17:34 Vincent Stehlé
  2014-04-06 17:47 ` Daniel Borkmann
  0 siblings, 1 reply; 2+ messages in thread
From: Vincent Stehlé @ 2014-04-06 17:34 UTC (permalink / raw)
  To: linux-kernel, netdev, linux-next; +Cc: Vincent Stehlé

The ETH_HLEN and VLAN_HLEN definitions are not in if.h any more. Add the
necessary includes to fix the following compilation errors:

  drivers/net/ethernet/ti/cpts.c: In function ‘cpts_match’:
  drivers/net/ethernet/ti/cpts.c:266:12: error: ‘ETH_HLEN’ undeclared (first use in this function)
  drivers/net/ethernet/ti/cpts.c:266:12: note: each undeclared identifier is reported only once for each function it appears in
  drivers/net/ethernet/ti/cpts.c:276:23: error: ‘VLAN_HLEN’ undeclared (first use in this function)

Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
---


Hi,

This compilation error can be seen with e.g. arm allmodconfig.

Best regards,

V.


 drivers/net/ethernet/ti/cpts.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index a3bbf59..2a2f82a 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -19,6 +19,8 @@
  */
 #include <linux/err.h>
 #include <linux/if.h>
+#include <linux/if_ether.h>
+#include <linux/if_vlan.h>
 #include <linux/hrtimer.h>
 #include <linux/module.h>
 #include <linux/net_tstamp.h>
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cpts: Fix missing includes
  2014-04-06 17:34 [PATCH] cpts: Fix missing includes Vincent Stehlé
@ 2014-04-06 17:47 ` Daniel Borkmann
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Borkmann @ 2014-04-06 17:47 UTC (permalink / raw)
  To: Vincent Stehlé; +Cc: linux-kernel, netdev, linux-next

On 04/06/2014 07:34 PM, Vincent Stehlé wrote:
> The ETH_HLEN and VLAN_HLEN definitions are not in if.h any more. Add the
> necessary includes to fix the following compilation errors:
>
>    drivers/net/ethernet/ti/cpts.c: In function ‘cpts_match’:
>    drivers/net/ethernet/ti/cpts.c:266:12: error: ‘ETH_HLEN’ undeclared (first use in this function)
>    drivers/net/ethernet/ti/cpts.c:266:12: note: each undeclared identifier is reported only once for each function it appears in
>    drivers/net/ethernet/ti/cpts.c:276:23: error: ‘VLAN_HLEN’ undeclared (first use in this function)
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>

Thanks, fix is already in net tree ...

https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=79eb9d28c9b22fa419e2c3f1b2cc6e285720ae41

> diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
> index a3bbf59..2a2f82a 100644
> --- a/drivers/net/ethernet/ti/cpts.c
> +++ b/drivers/net/ethernet/ti/cpts.c
> @@ -19,6 +19,8 @@
>    */
>   #include <linux/err.h>
>   #include <linux/if.h>
> +#include <linux/if_ether.h>
> +#include <linux/if_vlan.h>
>   #include <linux/hrtimer.h>
>   #include <linux/module.h>
>   #include <linux/net_tstamp.h>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-06 17:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-06 17:34 [PATCH] cpts: Fix missing includes Vincent Stehlé
2014-04-06 17:47 ` Daniel Borkmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.