From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v7 3/3] ARM: dts: add dts files for xyref5260 board Date: Wed, 09 Apr 2014 12:52:02 +0200 Message-ID: <53452652.7040304@samsung.com> References: <1396519224-18712-1-git-send-email-rahul.sharma@samsung.com> <1396519224-18712-4-git-send-email-rahul.sharma@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Sender: linux-samsung-soc-owner@vger.kernel.org To: Sachin Kamat , Rahul Sharma Cc: linux-samsung-soc , "devicetree@vger.kernel.org" , linux-arm-kernel , Kukjin Kim , Tomasz Figa , sunil joshi , Rahul Sharma List-Id: devicetree@vger.kernel.org On 07.04.2014 10:40, Sachin Kamat wrote: > On 3 April 2014 15:30, Rahul Sharma wrote: >> The patch adds the dts files for xyref5260 board which >> is based on Exynos5260 Evt0 sample. >> >> Signed-off-by: Rahul Sharma >> --- > >> +/ { >> + model = "SAMSUNG XYREF5260 EVT0 board based on EXYNOS5260"; >> + compatible = "samsung,xyref5260", "samsung,exynos5260"; > > "samsung,exynos5260" is OK here for future compatibility (if soc > specific quirk is required). > Please also add "samsung,exynos5" to compatible list. > Right. SoC family compatible string should be added between board and SoC model strings. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: t.figa@samsung.com (Tomasz Figa) Date: Wed, 09 Apr 2014 12:52:02 +0200 Subject: [PATCH v7 3/3] ARM: dts: add dts files for xyref5260 board In-Reply-To: References: <1396519224-18712-1-git-send-email-rahul.sharma@samsung.com> <1396519224-18712-4-git-send-email-rahul.sharma@samsung.com> Message-ID: <53452652.7040304@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07.04.2014 10:40, Sachin Kamat wrote: > On 3 April 2014 15:30, Rahul Sharma wrote: >> The patch adds the dts files for xyref5260 board which >> is based on Exynos5260 Evt0 sample. >> >> Signed-off-by: Rahul Sharma >> --- > >> +/ { >> + model = "SAMSUNG XYREF5260 EVT0 board based on EXYNOS5260"; >> + compatible = "samsung,xyref5260", "samsung,exynos5260"; > > "samsung,exynos5260" is OK here for future compatibility (if soc > specific quirk is required). > Please also add "samsung,exynos5" to compatible list. > Right. SoC family compatible string should be added between board and SoC model strings. Best regards, Tomasz