From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:45284 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754776AbdCIN43 (ORCPT ); Thu, 9 Mar 2017 08:56:29 -0500 Subject: Re: [PATCH rfc 03/10] nvme-pci: open-code polling logic in nvme_poll To: Sagi Grimberg , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, target-devel@vger.kernel.org References: <1489065402-14757-1-git-send-email-sagi@grimberg.me> <1489065402-14757-4-git-send-email-sagi@grimberg.me> From: Johannes Thumshirn Message-ID: <534565a7-4a8d-d125-49db-c8679f716466@suse.de> Date: Thu, 9 Mar 2017 14:56:27 +0100 MIME-Version: 1.0 In-Reply-To: <1489065402-14757-4-git-send-email-sagi@grimberg.me> Content-Type: text/plain; charset=windows-1252 Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On 03/09/2017 02:16 PM, Sagi Grimberg wrote: > Given that the code is simple enough it seems better > then passing a tag by reference for each call site. > > Signed-off-by: Sagi Grimberg > --- Deja-vu again? Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg GF: Felix Imend�rffer, Jane Smithard, Graham Norton HRB 21284 (AG N�rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Thumshirn Subject: Re: [PATCH rfc 03/10] nvme-pci: open-code polling logic in nvme_poll Date: Thu, 9 Mar 2017 14:56:27 +0100 Message-ID: <534565a7-4a8d-d125-49db-c8679f716466@suse.de> References: <1489065402-14757-1-git-send-email-sagi@grimberg.me> <1489065402-14757-4-git-send-email-sagi@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1489065402-14757-4-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 03/09/2017 02:16 PM, Sagi Grimberg wrote: > Given that the code is simple enough it seems better > then passing a tag by reference for each call site. > > Signed-off-by: Sagi Grimberg > --- Deja-vu again? Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn-l3A5Bk7waGM@public.gmane.org +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: jthumshirn@suse.de (Johannes Thumshirn) Date: Thu, 9 Mar 2017 14:56:27 +0100 Subject: [PATCH rfc 03/10] nvme-pci: open-code polling logic in nvme_poll In-Reply-To: <1489065402-14757-4-git-send-email-sagi@grimberg.me> References: <1489065402-14757-1-git-send-email-sagi@grimberg.me> <1489065402-14757-4-git-send-email-sagi@grimberg.me> Message-ID: <534565a7-4a8d-d125-49db-c8679f716466@suse.de> On 03/09/2017 02:16 PM, Sagi Grimberg wrote: > Given that the code is simple enough it seems better > then passing a tag by reference for each call site. > > Signed-off-by: Sagi Grimberg > --- Deja-vu again? Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn at suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850