From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v2 01/10] hvm/hpet: Add manual unit test code. Date: Thu, 10 Apr 2014 07:11:28 +0100 Message-ID: <534652300200007800007727@nat28.tlf.novell.com> References: <1396967094-29484-1-git-send-email-dslutz@verizon.com> <1396967094-29484-2-git-send-email-dslutz@verizon.com> <53458CB40200007800007598@nat28.tlf.novell.com> <534592D7.2020805@terremark.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <534592D7.2020805@terremark.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Don Slutz Cc: Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org >>> On 09.04.14 at 20:35, wrote: > On 04/09/14 12:08, Jan Beulich wrote: >>>>> On 08.04.14 at 16:24, wrote: >>> Add the code at tools/tests/vhpet. >>> >>> Does repro the bug: >>> >>> ..MP-BIOS bug: 8254 timer not connected to IO-APIC >>> >>> Signed-off-by: Don Slutz >>> --- >>> tools/tests/vhpet/.gitignore | 4 + >>> tools/tests/vhpet/emul.h | 405 ++++++++++++++++++++++++++++++++ >>> tools/tests/vhpet/main.c | 541 +++++++++++++++++++++++++++++++++++++++++++ >> So I'm having difficulty understanding what this is good for, or how >> it is supposed to be used: You don't add or change any Makefile, and >> don't say anything to explain how this code is reproducing the bug >> you mention above. Please be a little more verbose. > > In a xen source tree (with this patch applied): > > cd tools/tests/vhpet > > xen_source=../../.. > sed -e "/#include/d" -e "1i#include \"emul.h\"\n" <$xen_source/xen/arch/x86/hvm/hpet.c >hpet.c > cp $xen_source/xen/include/asm-x86/hpet.h . > > gcc -g -o test_vhpet hpet.c main.c At least up to here this clearly should be in a Makefile, just like e.g. done for the x86 instruction emulator test. > ./test_vhpet >foo > > > Most of this is in main.c's comment. Will add to commit message also. Just referring to the comments there would be enough I guess. But I'm still struggling to see how this would reproduce the Linux side issue, and not just some random problem manifesting in similar symptoms. Jan