From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYGH4-0006Wz-6q for qemu-devel@nongnu.org; Thu, 10 Apr 2014 10:48:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYGGz-0006jY-Hk for qemu-devel@nongnu.org; Thu, 10 Apr 2014 10:48:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYGGz-0006jG-8i for qemu-devel@nongnu.org; Thu, 10 Apr 2014 10:48:13 -0400 Message-ID: <5346AF2A.3050701@redhat.com> Date: Thu, 10 Apr 2014 08:48:10 -0600 From: Eric Blake MIME-Version: 1.0 References: <10015a278ac01aa8f6848bf89d433c91e3184b76.1397097046.git.jcody@redhat.com> <20140410075357.GF22890@T430.nay.redhat.com> <20140410125356.GD4859@localhost.localdomain> <5346AE20.4040903@redhat.com> In-Reply-To: <5346AE20.4040903@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="glQCBMAhdlouW8VRWbsCJ5bl7elFHNiqH" Subject: Re: [Qemu-devel] [PATCH v2 4/5] block: qemu-iotests - fix image cleanup when using spaced pathnames List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, benoit@irqsave.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --glQCBMAhdlouW8VRWbsCJ5bl7elFHNiqH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/10/2014 08:43 AM, Eric Blake wrote: > On 04/10/2014 06:53 AM, Jeff Cody wrote: >=20 >>>> +++ b/tests/qemu-iotests/common.rc >>>> @@ -178,10 +178,10 @@ _rm_test_img() >>>> local img=3D$1 >>> >>> Since we are quoting $img, should we quote $1 as well? >>> >=20 > http://austingroupbugs.net/view.php?id=3D351 >=20 > But even with the notion of an assignment-context argument added to a > future version of POSIX, the reality is that given the present standard= , > it's safer to either use "" to ensure no word splitting: Well, if you were trying to be portable to multiple shells, then it would matter. But as this script is explicitly being run under /bin/bash, and as bash already has support for declaration utilities where local is one such utility, your script as written is safe without "" in the arguments to local. So I'm fine whether you choose to change it in a respin or to leave it as written in this version. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --glQCBMAhdlouW8VRWbsCJ5bl7elFHNiqH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTRq8qAAoJEKeha0olJ0NqIuUH/0k9CLYJ+ODvth0gZ528mAg8 KtoviE5io9QqdnWeY4aMbVIK8akHzobE+CMi2wiHKn1ZMg3ynGNEknk+H51Eno/g Blt4fcYeIgI2iuj8uEsKxRa8kODRrGYlgHq2LmVXOtJzKIOhAB0oXEbKkYjL9Q0s H3lPG6gf7hgbP09phaFrA3THNO4sLfCNZ/9QxFJNewiX5sDY2J1Xts4FX26jwBxo WarRQA/KqEzQT0IUXmHYplEKKGQlL4JuBVuyTLLaOrxabaEwXsE3ive/3t53s48l QSmGW7BY+ipatCG7YED/hi55M0ZYYvxapYLeKByMaaOuPxfP9tW4YI/pbCiZ1Oo= =8PoV -----END PGP SIGNATURE----- --glQCBMAhdlouW8VRWbsCJ5bl7elFHNiqH--