Re: [yavta PATCH 5/9] Allow passing file descriptors to yavta

From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [yavta PATCH 5/9] Allow passing file descriptors to yavta
Date: Thu, 10 Apr 2014 21:48:55 +0300	[thread overview]
Message-ID: <5346E797.5070503@iki.fi> (raw)
In-Reply-To: <349099482.s11F5mBja6@avalon>

Hi Laurent,

Thanks for the comments.

Laurent Pinchart wrote:
...
>> @@ -196,6 +192,16 @@ static int video_open(struct device *dev, const char
>> *devname, int no_query)
>>
>>   	printf("Device %s opened.\n", devname);
>>
>> +	dev->opened = 1;
>> +
>> +	return 0;
>> +}
>> +
>> +static int video_querycap(struct device *dev, int no_query) {
>> +	struct v4l2_capability cap;
>> +	unsigned int capabilities;
>> +	int ret;
>> +
>
> video_querycap ends up setting the dev->type field, which isn't really the job
> of a query function. Would there be a clean way to pass the fd to the
> video_open() function instead ? Maybe video_open() could be split and/or
> renamed to video_init() ?

Agreed. I'll separate queue type selection from querycap. As the 
querycap needs to be done after opening the device, I'll put it into 
another function. I'm ok with video_init(), but what would you think 
about e.g. video_set_queue_type() as the function does nothing else.

-- 
Regards,

Sakari Ailus
sakari.ailus@iki.fi