From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYXeF-0005ZW-VV for qemu-devel@nongnu.org; Fri, 11 Apr 2014 05:21:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYXe9-00065P-IU for qemu-devel@nongnu.org; Fri, 11 Apr 2014 05:21:23 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56277 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYXe9-00065A-CY for qemu-devel@nongnu.org; Fri, 11 Apr 2014 05:21:17 -0400 Message-ID: <5347B409.6050105@suse.de> Date: Fri, 11 Apr 2014 11:21:13 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1397057589-11779-1-git-send-email-eric.auger@linaro.org> <1397057589-11779-2-git-send-email-eric.auger@linaro.org> <5346A148.4040004@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 1/6] hw/arm/virt: add a xgmac device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: Peter Maydell , Peter Crosthwaite , Kim Phillips , eric.auger@st.com, Eric Auger , Kim Phillips , "qemu-devel@nongnu.org Developers" , stuart.yoder@freescale.com, alex.williamson@redhat.com, christophe.barnichon@st.com, a.motakis@virtualopensystems.com, "kvmarm@lists.cs.columbia.edu" , Christoffer Dall On 11.04.14 07:41, Alistair Francis wrote: > On Thu, Apr 10, 2014 at 11:48 PM, Alexander Graf wrote: >> On 10.04.14 15:26, Peter Crosthwaite wrote: >>> On Thu, Apr 10, 2014 at 1:33 AM, Eric Auger wrote: >>>> From: Kim Phillips >>>> >>>> This is a hack and only serves as an example of what needs to be >>>> done to make the next RFC - add vfio-platform support - work >>>> for development purposes on a Calxeda Midway system. We don't want >>>> mach-virt to always create this ethernet device - DO NOT APPLY, etc. >>>> >>>> Initial attempts to convince QEMU to create a memory mapped device >>>> on the command line (e.g., -device vfio-platform,name=fff51000.ethernet) >>>> would fail with "Parameter 'driver' expects pluggable device type". >>> Alistair is working on this. cc. >> >> Alaistair, I've had patches tackle this on the mailing list a few months ago >> and received good comments from Anthony on what to change. How far in are >> you already? I'd like to make sure we're on the same page here (and don't >> duplicate work). >> >> >> Alex >> >> > Hey Alex, > > I have a patch I'm about to send to the mailing list. It allows an > entire machine to be added by the -device argument on the command > line. It is a similar implementation to my first version (vl.c: Allow > sysbus devices to be attached via commandline), but much more generic. > > Could you point me to your patches so I can compare? At the moment I > don't have much feedback to my implementation Sure. It's right here: https://lists.gnu.org/archive/html/qemu-devel/2013-07/msg03614.html But as you can see there was quite a bit of discussion on that thread on how to do it right. Alex