* [PATCH 1/3] migration dirtybitmap support ARMv7
@ 2014-04-15 1:24 Mario Smarduch
2014-04-15 8:22 ` Marc Zyngier
0 siblings, 1 reply; 2+ messages in thread
From: Mario Smarduch @ 2014-04-15 1:24 UTC (permalink / raw)
To: kvmarm, christoffer.dall, marc.zyngier, 이정석,
정성진
Cc: kvm
Headers for migration, prototypes
Signed-off-by: Mario Smarduch <m.smarduch@samsung.com>
---
arch/arm/include/asm/kvm_host.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h
index 098f7dd..9b71f13 100644
--- a/arch/arm/include/asm/kvm_host.h
+++ b/arch/arm/include/asm/kvm_host.h
@@ -67,6 +67,7 @@ struct kvm_arch {
/* Interrupt controller */
struct vgic_dist vgic;
+ int migration_in_progress;
};
#define KVM_NR_MEM_OBJS 40
@@ -228,4 +229,12 @@ int kvm_perf_teardown(void);
u64 kvm_arm_timer_get_reg(struct kvm_vcpu *, u64 regid);
int kvm_arm_timer_set_reg(struct kvm_vcpu *, u64 regid, u64 value);
+void kvm_mmu_slot_remove_write_access(struct kvm *kvm, int slot);
+
+void kvm_mmu_write_protect_pt_masked(struct kvm *kvm,
+ struct kvm_memory_slot *slot,
+ gfn_t gfn_offset, unsigned long mask);
+
+void kvm_tlb_flush_vmid(struct kvm *kvm);
+
#endif /* __ARM_KVM_HOST_H__ */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] migration dirtybitmap support ARMv7
2014-04-15 1:24 [PATCH 1/3] migration dirtybitmap support ARMv7 Mario Smarduch
@ 2014-04-15 8:22 ` Marc Zyngier
0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2014-04-15 8:22 UTC (permalink / raw)
To: Mario Smarduch
Cc: kvmarm, christoffer.dall, 이정석,
정성진,
kvm
Hi Mario,
On 15/04/14 02:24, Mario Smarduch wrote:
>
> Headers for migration, prototypes
>
> Signed-off-by: Mario Smarduch <m.smarduch@samsung.com>
As a general comment in the whole series: Please take the time to write
decent commit messages. Having the same title for all three patches is
rather counter-productive, and I'd like to be able to tell what each
individual patch does just by reading the commit message.
Thanks!
> ---
> arch/arm/include/asm/kvm_host.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h
> index 098f7dd..9b71f13 100644
> --- a/arch/arm/include/asm/kvm_host.h
> +++ b/arch/arm/include/asm/kvm_host.h
> @@ -67,6 +67,7 @@ struct kvm_arch {
>
> /* Interrupt controller */
> struct vgic_dist vgic;
> + int migration_in_progress;
> };
>
> #define KVM_NR_MEM_OBJS 40
> @@ -228,4 +229,12 @@ int kvm_perf_teardown(void);
> u64 kvm_arm_timer_get_reg(struct kvm_vcpu *, u64 regid);
> int kvm_arm_timer_set_reg(struct kvm_vcpu *, u64 regid, u64 value);
>
> +void kvm_mmu_slot_remove_write_access(struct kvm *kvm, int slot);
> +
> +void kvm_mmu_write_protect_pt_masked(struct kvm *kvm,
> + struct kvm_memory_slot *slot,
> + gfn_t gfn_offset, unsigned long mask);
> +
> +void kvm_tlb_flush_vmid(struct kvm *kvm);
> +
> #endif /* __ARM_KVM_HOST_H__ */
>
This doesn't make much sense on its own. Consider squashing it in
another patch.
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-15 8:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-15 1:24 [PATCH 1/3] migration dirtybitmap support ARMv7 Mario Smarduch
2014-04-15 8:22 ` Marc Zyngier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.