All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] unicore32: include: asm: add missing ')' for PAGE_* macros in pgtable.h
@ 2014-04-15  1:49 Chen Gang
  2014-04-16  5:19 ` 回复: " 管雪涛
  0 siblings, 1 reply; 3+ messages in thread
From: Chen Gang @ 2014-04-15  1:49 UTC (permalink / raw)
  To: Guan Xuetao, viro; +Cc: linux-kernel

Missing related ')', the related compiling error:

    CC [M]  drivers/gpu/drm/udl/udl_fb.o
  drivers/gpu/drm/udl/udl_fb.c: In function ‘udl_fb_mmap’:
  drivers/gpu/drm/udl/udl_fb.c:273: error: expected ‘)’ before ‘return’
  drivers/gpu/drm/udl/udl_fb.c:281: error: expected expression before ‘}’ token
  make[4]: *** [drivers/gpu/drm/udl/udl_fb.o] Error 1
  make[3]: *** [drivers/gpu/drm/udl] Error 2
  make[2]: *** [drivers/gpu/drm] Error 2
  make[1]: *** [drivers/gpu] Error 2
  make: *** [drivers] Error 2


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/unicore32/include/asm/pgtable.h |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/unicore32/include/asm/pgtable.h b/arch/unicore32/include/asm/pgtable.h
index 233c258..ed6f7d0 100644
--- a/arch/unicore32/include/asm/pgtable.h
+++ b/arch/unicore32/include/asm/pgtable.h
@@ -87,16 +87,16 @@ extern pgprot_t pgprot_kernel;
 
 #define PAGE_NONE		pgprot_user
 #define PAGE_SHARED		__pgprot(pgprot_val(pgprot_user | PTE_READ \
-								| PTE_WRITE)
+								| PTE_WRITE))
 #define PAGE_SHARED_EXEC	__pgprot(pgprot_val(pgprot_user | PTE_READ \
 								| PTE_WRITE \
-								| PTE_EXEC)
+								| PTE_EXEC))
 #define PAGE_COPY		__pgprot(pgprot_val(pgprot_user | PTE_READ)
 #define PAGE_COPY_EXEC		__pgprot(pgprot_val(pgprot_user | PTE_READ \
-								| PTE_EXEC)
-#define PAGE_READONLY		__pgprot(pgprot_val(pgprot_user | PTE_READ)
+								| PTE_EXEC))
+#define PAGE_READONLY		__pgprot(pgprot_val(pgprot_user | PTE_READ))
 #define PAGE_READONLY_EXEC	__pgprot(pgprot_val(pgprot_user | PTE_READ \
-								| PTE_EXEC)
+								| PTE_EXEC))
 #define PAGE_KERNEL		pgprot_kernel
 #define PAGE_KERNEL_EXEC	__pgprot(pgprot_val(pgprot_kernel | PTE_EXEC))
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* 回复: [PATCH] unicore32: include: asm: add missing ')' for PAGE_* macros in pgtable.h
  2014-04-15  1:49 [PATCH] unicore32: include: asm: add missing ')' for PAGE_* macros in pgtable.h Chen Gang
@ 2014-04-16  5:19 ` 管雪涛
  2014-04-16  5:44   ` Chen Gang
  0 siblings, 1 reply; 3+ messages in thread
From: 管雪涛 @ 2014-04-16  5:19 UTC (permalink / raw)
  To: Chen Gang; +Cc: Guan Xuetao, viro, linux-kernel

This problem has been fixed, but I didn't submit.
Anyway, I can apply your version.

Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>

----- Chen Gang <gang.chen.5i5j@gmail.com> 写道:
> Missing related ')', the related compiling error:
> 
>     CC [M]  drivers/gpu/drm/udl/udl_fb.o
>   drivers/gpu/drm/udl/udl_fb.c: In function ‘udl_fb_mmap’:
>   drivers/gpu/drm/udl/udl_fb.c:273: error: expected ‘)’ before ‘return’
>   drivers/gpu/drm/udl/udl_fb.c:281: error: expected expression before ‘}’ token
>   make[4]: *** [drivers/gpu/drm/udl/udl_fb.o] Error 1
>   make[3]: *** [drivers/gpu/drm/udl] Error 2
>   make[2]: *** [drivers/gpu/drm] Error 2
>   make[1]: *** [drivers/gpu] Error 2
>   make: *** [drivers] Error 2
> 
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  arch/unicore32/include/asm/pgtable.h |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/unicore32/include/asm/pgtable.h b/arch/unicore32/include/asm/pgtable.h
> index 233c258..ed6f7d0 100644
> --- a/arch/unicore32/include/asm/pgtable.h
> +++ b/arch/unicore32/include/asm/pgtable.h
> @@ -87,16 +87,16 @@ extern pgprot_t pgprot_kernel;
>  
>  #define PAGE_NONE		pgprot_user
>  #define PAGE_SHARED		__pgprot(pgprot_val(pgprot_user | PTE_READ \
> -								| PTE_WRITE)
> +								| PTE_WRITE))
>  #define PAGE_SHARED_EXEC	__pgprot(pgprot_val(pgprot_user | PTE_READ \
>  								| PTE_WRITE \
> -								| PTE_EXEC)
> +								| PTE_EXEC))
>  #define PAGE_COPY		__pgprot(pgprot_val(pgprot_user | PTE_READ)
>  #define PAGE_COPY_EXEC		__pgprot(pgprot_val(pgprot_user | PTE_READ \
> -								| PTE_EXEC)
> -#define PAGE_READONLY		__pgprot(pgprot_val(pgprot_user | PTE_READ)
> +								| PTE_EXEC))
> +#define PAGE_READONLY		__pgprot(pgprot_val(pgprot_user | PTE_READ))
>  #define PAGE_READONLY_EXEC	__pgprot(pgprot_val(pgprot_user | PTE_READ \
> -								| PTE_EXEC)
> +								| PTE_EXEC))
>  #define PAGE_KERNEL		pgprot_kernel
>  #define PAGE_KERNEL_EXEC	__pgprot(pgprot_val(pgprot_kernel | PTE_EXEC))
>  
> -- 
> 1.7.9.5


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: 回复: [PATCH] unicore32: include: asm: add missing ')' for PAGE_* macros in pgtable.h
  2014-04-16  5:19 ` 回复: " 管雪涛
@ 2014-04-16  5:44   ` Chen Gang
  0 siblings, 0 replies; 3+ messages in thread
From: Chen Gang @ 2014-04-16  5:44 UTC (permalink / raw)
  To: 管雪涛; +Cc: Guan Xuetao, viro, linux-kernel

On 04/16/2014 01:19 PM, 管雪涛 wrote:
> This problem has been fixed, but I didn't submit.
> Anyway, I can apply your version.
> 
> Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>
> 

OK, thanks.

> ----- Chen Gang <gang.chen.5i5j@gmail.com> 写道:
>> Missing related ')', the related compiling error:
>>
>>     CC [M]  drivers/gpu/drm/udl/udl_fb.o
>>   drivers/gpu/drm/udl/udl_fb.c: In function ‘udl_fb_mmap’:
>>   drivers/gpu/drm/udl/udl_fb.c:273: error: expected ‘)’ before ‘return’
>>   drivers/gpu/drm/udl/udl_fb.c:281: error: expected expression before ‘}’ token
>>   make[4]: *** [drivers/gpu/drm/udl/udl_fb.o] Error 1
>>   make[3]: *** [drivers/gpu/drm/udl] Error 2
>>   make[2]: *** [drivers/gpu/drm] Error 2
>>   make[1]: *** [drivers/gpu] Error 2
>>   make: *** [drivers] Error 2
>>
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>>  arch/unicore32/include/asm/pgtable.h |   10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/unicore32/include/asm/pgtable.h b/arch/unicore32/include/asm/pgtable.h
>> index 233c258..ed6f7d0 100644
>> --- a/arch/unicore32/include/asm/pgtable.h
>> +++ b/arch/unicore32/include/asm/pgtable.h
>> @@ -87,16 +87,16 @@ extern pgprot_t pgprot_kernel;
>>  
>>  #define PAGE_NONE		pgprot_user
>>  #define PAGE_SHARED		__pgprot(pgprot_val(pgprot_user | PTE_READ \
>> -								| PTE_WRITE)
>> +								| PTE_WRITE))
>>  #define PAGE_SHARED_EXEC	__pgprot(pgprot_val(pgprot_user | PTE_READ \
>>  								| PTE_WRITE \
>> -								| PTE_EXEC)
>> +								| PTE_EXEC))
>>  #define PAGE_COPY		__pgprot(pgprot_val(pgprot_user | PTE_READ)
>>  #define PAGE_COPY_EXEC		__pgprot(pgprot_val(pgprot_user | PTE_READ \
>> -								| PTE_EXEC)
>> -#define PAGE_READONLY		__pgprot(pgprot_val(pgprot_user | PTE_READ)
>> +								| PTE_EXEC))
>> +#define PAGE_READONLY		__pgprot(pgprot_val(pgprot_user | PTE_READ))
>>  #define PAGE_READONLY_EXEC	__pgprot(pgprot_val(pgprot_user | PTE_READ \
>> -								| PTE_EXEC)
>> +								| PTE_EXEC))
>>  #define PAGE_KERNEL		pgprot_kernel
>>  #define PAGE_KERNEL_EXEC	__pgprot(pgprot_val(pgprot_kernel | PTE_EXEC))
>>  
>> -- 
>> 1.7.9.5
> 

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-04-16  5:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-15  1:49 [PATCH] unicore32: include: asm: add missing ')' for PAGE_* macros in pgtable.h Chen Gang
2014-04-16  5:19 ` 回复: " 管雪涛
2014-04-16  5:44   ` Chen Gang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.