From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Date: Tue, 15 Apr 2014 07:01:44 +0000 Subject: Re: [PATCHv2 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup Message-Id: <534CD958.4000303@ti.com> List-Id: References: <1397512793-10325-1-git-send-email-alexandre.belloni@free-electrons.com> <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com> In-Reply-To: <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-arm-kernel@lists.infradead.org On 04/15/2014 12:59 AM, Alexandre Belloni wrote: > Signed-off-by: Alexandre Belloni > --- > arch/arm/mach-omap2/board-omap3beagle.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) >=20 > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap= 2/board-omap3beagle.c > index f27e1ec90b5e..54c135a5b4f7 100644 > --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > @@ -61,14 +61,8 @@ > =20 > static struct pwm_lookup pwm_lookup[] =3D { > /* LEDB -> PMU_STAT */ > - { > - .provider =3D "twl-pwmled", > - .index =3D 1, > - .dev_id =3D "leds_pwm", > - .con_id =3D "beagleboard::pmu_stat", > - .period =3D 7812500, > - .polarity =3D PWM_POLARITY_NORMAL, > - }, > + PWM_LOOKUP("twl-pwmled", 1, "leds_pwm", "beagleboard::pmu_stat", > + 7812500, PWM_POLARITY_NORMAL), Why do you need to do this in two steps? In patch 4 you removed the existing PWM_LOOKUP() and now you are adding it = back. Would not be simpler if you just add the two new parameters in patch 4 (the 812500, PWM_POLARITY_NORMAL)? > }; > =20 > static struct led_pwm pwm_leds[] =3D { >=20 --=20 P=E9ter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCHv2 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup Date: Tue, 15 Apr 2014 10:01:44 +0300 Message-ID: <534CD958.4000303@ti.com> References: <1397512793-10325-1-git-send-email-alexandre.belloni@free-electrons.com> <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com> Sender: linux-omap-owner@vger.kernel.org To: Alexandre Belloni , Thierry Reding Cc: Tony Lindgren , Philipp Zabel , Paul Parsons , Simon Horman , Magnus Damm , Eric Miao , Haojian Zhuang , Bryan Wu , Jingoo Han , Lee Jones , linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-sh@vger.kernel.org, linux-leds@vger.kernel.org, linux-fbdev@vger.kernel.org List-Id: linux-leds@vger.kernel.org On 04/15/2014 12:59 AM, Alexandre Belloni wrote: > Signed-off-by: Alexandre Belloni > --- > arch/arm/mach-omap2/board-omap3beagle.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) >=20 > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-= omap2/board-omap3beagle.c > index f27e1ec90b5e..54c135a5b4f7 100644 > --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > @@ -61,14 +61,8 @@ > =20 > static struct pwm_lookup pwm_lookup[] =3D { > /* LEDB -> PMU_STAT */ > - { > - .provider =3D "twl-pwmled", > - .index =3D 1, > - .dev_id =3D "leds_pwm", > - .con_id =3D "beagleboard::pmu_stat", > - .period =3D 7812500, > - .polarity =3D PWM_POLARITY_NORMAL, > - }, > + PWM_LOOKUP("twl-pwmled", 1, "leds_pwm", "beagleboard::pmu_stat", > + 7812500, PWM_POLARITY_NORMAL), Why do you need to do this in two steps? In patch 4 you removed the existing PWM_LOOKUP() and now you are adding= it back. Would not be simpler if you just add the two new parameters in patch 4 = (the 812500, PWM_POLARITY_NORMAL)? > }; > =20 > static struct led_pwm pwm_leds[] =3D { >=20 --=20 P=E9ter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752008AbaDOHCl (ORCPT ); Tue, 15 Apr 2014 03:02:41 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:56129 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751224AbaDOHCX (ORCPT ); Tue, 15 Apr 2014 03:02:23 -0400 Message-ID: <534CD958.4000303@ti.com> Date: Tue, 15 Apr 2014 10:01:44 +0300 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Alexandre Belloni , Thierry Reding CC: Tony Lindgren , Philipp Zabel , Paul Parsons , Simon Horman , Magnus Damm , Eric Miao , Haojian Zhuang , Bryan Wu , Jingoo Han , Lee Jones , , , , , , , Subject: Re: [PATCHv2 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup References: <1397512793-10325-1-git-send-email-alexandre.belloni@free-electrons.com> <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com> In-Reply-To: <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/15/2014 12:59 AM, Alexandre Belloni wrote: > Signed-off-by: Alexandre Belloni > --- > arch/arm/mach-omap2/board-omap3beagle.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c > index f27e1ec90b5e..54c135a5b4f7 100644 > --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > @@ -61,14 +61,8 @@ > > static struct pwm_lookup pwm_lookup[] = { > /* LEDB -> PMU_STAT */ > - { > - .provider = "twl-pwmled", > - .index = 1, > - .dev_id = "leds_pwm", > - .con_id = "beagleboard::pmu_stat", > - .period = 7812500, > - .polarity = PWM_POLARITY_NORMAL, > - }, > + PWM_LOOKUP("twl-pwmled", 1, "leds_pwm", "beagleboard::pmu_stat", > + 7812500, PWM_POLARITY_NORMAL), Why do you need to do this in two steps? In patch 4 you removed the existing PWM_LOOKUP() and now you are adding it back. Would not be simpler if you just add the two new parameters in patch 4 (the 812500, PWM_POLARITY_NORMAL)? > }; > > static struct led_pwm pwm_leds[] = { > -- Péter From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.ujfalusi@ti.com (Peter Ujfalusi) Date: Tue, 15 Apr 2014 10:01:44 +0300 Subject: [PATCHv2 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup In-Reply-To: <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com> References: <1397512793-10325-1-git-send-email-alexandre.belloni@free-electrons.com> <1397512793-10325-8-git-send-email-alexandre.belloni@free-electrons.com> Message-ID: <534CD958.4000303@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/15/2014 12:59 AM, Alexandre Belloni wrote: > Signed-off-by: Alexandre Belloni > --- > arch/arm/mach-omap2/board-omap3beagle.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c > index f27e1ec90b5e..54c135a5b4f7 100644 > --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > @@ -61,14 +61,8 @@ > > static struct pwm_lookup pwm_lookup[] = { > /* LEDB -> PMU_STAT */ > - { > - .provider = "twl-pwmled", > - .index = 1, > - .dev_id = "leds_pwm", > - .con_id = "beagleboard::pmu_stat", > - .period = 7812500, > - .polarity = PWM_POLARITY_NORMAL, > - }, > + PWM_LOOKUP("twl-pwmled", 1, "leds_pwm", "beagleboard::pmu_stat", > + 7812500, PWM_POLARITY_NORMAL), Why do you need to do this in two steps? In patch 4 you removed the existing PWM_LOOKUP() and now you are adding it back. Would not be simpler if you just add the two new parameters in patch 4 (the 812500, PWM_POLARITY_NORMAL)? > }; > > static struct led_pwm pwm_leds[] = { > -- P?ter