From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v2 07/10] hvm/hpet: Call hpet_get_comparator during hpet_save. Date: Tue, 15 Apr 2014 08:06:17 +0100 Message-ID: <534CF6890200007800008CD4@nat28.tlf.novell.com> References: <1396967094-29484-1-git-send-email-dslutz@verizon.com> <1396967094-29484-8-git-send-email-dslutz@verizon.com> <534C175202000078000088CE@nat28.tlf.novell.com> <534C7B7D.7070609@terremark.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <534C7B7D.7070609@terremark.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Don Slutz Cc: Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org >>> On 15.04.14 at 02:21, wrote: > On 04/14/14 11:13, Jan Beulich wrote: >>>>> On 08.04.14 at 16:24, wrote: >>> This changes save data to consistent/expected values. It is not >>> technically required because hpet_get_comparator() will adjust from >>> any value to the correct value. >> So am I getting it right that this is just to alter what's in the save image >> then? > > Yes. > >> I'm somewhat confused by the wording above, which I first read >> mostly like "here is a change that we don't need". > > This is a change that is only "needed" with patch #10 > "handle 1st period special". > > However it does look strange to people > that the output from xen-hvmctx for the comparator > values do not change when the master clock does. Maybe you should mention that aspect then in the commit message? Jan