From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v2 06/10] hvm/hpet: comparator can only change when master clock is enabled. Date: Wed, 16 Apr 2014 09:42:34 +0100 Message-ID: <534E5E9A0200007800009576@nat28.tlf.novell.com> References: <1396967094-29484-1-git-send-email-dslutz@verizon.com> <1396967094-29484-7-git-send-email-dslutz@verizon.com> <534C15E902000078000088C4@nat28.tlf.novell.com> <534C3C1A.7090002@terremark.com> <534CF6440200007800008CBF@nat28.tlf.novell.com> <534D560F.4000709@terremark.com> <534D771C02000078000091EE@nat28.tlf.novell.com> <534D764A.7010606@terremark.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <534D764A.7010606@terremark.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Don Slutz Cc: Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org >>> On 15.04.14 at 20:11, wrote: > Since this is all about when master clock is not enabled, I will > work with hpet_read_maincounter() returning a fix value. I will > also only talk about timer 0 (tn==0). > > Since master clock, comparator, and period can all be set by > the guest, ... Oh, okay, this is the piece I ignored so far - I assumed that the values would be unchanged from when last updated by the hypervisor. IOW I agree with the change then, but would ask for the description to point out why this is needed in a more explicit fashion. Jan