From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754427AbaDRTvw (ORCPT ); Fri, 18 Apr 2014 15:51:52 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:46994 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754008AbaDRTvI (ORCPT ); Fri, 18 Apr 2014 15:51:08 -0400 Message-ID: <5351822B.7010402@cogentembedded.com> Date: Fri, 18 Apr 2014 23:51:07 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Iyappan Subramanian , davem@davemloft.net, netdev@vger.kernel.org, devicetree@vger.kernel.org CC: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jcm@redhat.com, patches@apm.com, Ravi Patel , Keyur Chudgar Subject: Re: [PATCH v2 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver References: <1397271984-23405-1-git-send-email-isubramanian@apm.com> <1397271984-23405-3-git-send-email-isubramanian@apm.com> In-Reply-To: <1397271984-23405-3-git-send-email-isubramanian@apm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 04/12/2014 07:06 AM, Iyappan Subramanian wrote: > This patch adds documentation for APM X-Gene SoC ethernet DTS binding. > Signed-off-by: Iyappan Subramanian > Signed-off-by: Ravi Patel > Signed-off-by: Keyur Chudgar > --- > .../devicetree/bindings/net/apm-xgene-enet.txt | 46 ++++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/apm-xgene-enet.txt > diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt > new file mode 100644 > index 0000000..0c983e8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt > @@ -0,0 +1,46 @@ > +APM X-Gene SoC Ethernet nodes > + > +Ethernet nodes are defined to describe on-chip ethernet interfaces in > +APM X-Gene SoC. > + > +Required properties: > +- compatible : Should be "apm,xgene-enet" > +- reg : First resource is the ethernet base register set > + Second resource is the ring base register set > + Third resource is the ring command register set > +- interrupts : Ethernet main interrupt > +- clocks : Reference to the clock entry. > +- local-mac-address : Ethernet MAC address. This property is described in Documentation/devicetree/bindings/net/ethernet.txt, please refer to it. > +- phy-addr : Ethernet MII phy address. No, thus won't do. Please use "phy-handle" property to refer to a PHY subnode. > +- phy-mode : Ethernet MII mode. This one is described in Documentation/devicetree/bindings/net/ethernet.txt as well. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Fri, 18 Apr 2014 23:51:07 +0400 Subject: [PATCH v2 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver In-Reply-To: <1397271984-23405-3-git-send-email-isubramanian@apm.com> References: <1397271984-23405-1-git-send-email-isubramanian@apm.com> <1397271984-23405-3-git-send-email-isubramanian@apm.com> Message-ID: <5351822B.7010402@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 04/12/2014 07:06 AM, Iyappan Subramanian wrote: > This patch adds documentation for APM X-Gene SoC ethernet DTS binding. > Signed-off-by: Iyappan Subramanian > Signed-off-by: Ravi Patel > Signed-off-by: Keyur Chudgar > --- > .../devicetree/bindings/net/apm-xgene-enet.txt | 46 ++++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/apm-xgene-enet.txt > diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt > new file mode 100644 > index 0000000..0c983e8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt > @@ -0,0 +1,46 @@ > +APM X-Gene SoC Ethernet nodes > + > +Ethernet nodes are defined to describe on-chip ethernet interfaces in > +APM X-Gene SoC. > + > +Required properties: > +- compatible : Should be "apm,xgene-enet" > +- reg : First resource is the ethernet base register set > + Second resource is the ring base register set > + Third resource is the ring command register set > +- interrupts : Ethernet main interrupt > +- clocks : Reference to the clock entry. > +- local-mac-address : Ethernet MAC address. This property is described in Documentation/devicetree/bindings/net/ethernet.txt, please refer to it. > +- phy-addr : Ethernet MII phy address. No, thus won't do. Please use "phy-handle" property to refer to a PHY subnode. > +- phy-mode : Ethernet MII mode. This one is described in Documentation/devicetree/bindings/net/ethernet.txt as well. WBR, Sergei