From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Date: Thu, 30 Jun 2016 03:37:18 +0200 Message-ID: <5351858.jEb0qfTvrF@vostro.rjw.lan> References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Fu Wei Cc: "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Hanjun Guo , "linux-arm-kernel@lists.infradead.org" , "linaro-acpi@lists.linaro.org" , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, harba@codeaurora.org, Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , wei@redhat.com, Arnd Bergmann , Wim Van Sebroeck , Catalin Marinas , Will Deacon , Suravee List-Id: linux-acpi@vger.kernel.org On Thursday, June 30, 2016 09:29:59 AM Fu Wei wrote: > Hi Rafael, > > On 30 June 2016 at 05:32, Rafael J. Wysocki wrote: > > On Wed, Jun 29, 2016 at 8:15 PM, wrote: > >> From: Fu Wei > >> > >> This patchset: > >> (1)Preparation for adding GTDT support in arm_arch_timer > >> 1. Move some enums and marcos to header file > >> 2. Add a new enum for spi type. > >> 3. Improve printk relevant code > >> > >> (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c > >> Parse all kinds of timer in GTDT table of ACPI:arch timer, > >> memory-mapped timer and SBSA Generic Watchdog timer. > >> This driver can help to simplify all the relevant timer drivers, > >> and separate all the ACPI GTDT knowledge from them. > >> > >> (3)Simplify ACPI code for arm_arch_timer > >> > >> (4)Add GTDT support for ARM memory-mapped timer > > > > GTDT is ARM-specific AFAICS. > > yes, you are right, it is. > > > > > If so, why do we need that code to reside in drivers/acpi/ ? > > Although the GTDT is just for ARM64, but this driver is parsing one > of ACPI table, > I think that could be treated as ACPI driver. Do I miss something? :-) Yes, you are. Nobody except for ARM64 will ever need it. Thanks, Rafael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbcF3Bcw (ORCPT ); Wed, 29 Jun 2016 21:32:52 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:57682 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751669AbcF3Bcu (ORCPT ); Wed, 29 Jun 2016 21:32:50 -0400 From: "Rafael J. Wysocki" To: Fu Wei Cc: "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Hanjun Guo , "linux-arm-kernel@lists.infradead.org" , "linaro-acpi@lists.linaro.org" , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, harba@codeaurora.org, Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , wei@redhat.com, Arnd Bergmann , Wim Van Sebroeck , Catalin Marinas , Will Deacon , Suravee Suthikulanit , Leo Duran Subject: Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Date: Thu, 30 Jun 2016 03:37:18 +0200 Message-ID: <5351858.jEb0qfTvrF@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, June 30, 2016 09:29:59 AM Fu Wei wrote: > Hi Rafael, > > On 30 June 2016 at 05:32, Rafael J. Wysocki wrote: > > On Wed, Jun 29, 2016 at 8:15 PM, wrote: > >> From: Fu Wei > >> > >> This patchset: > >> (1)Preparation for adding GTDT support in arm_arch_timer > >> 1. Move some enums and marcos to header file > >> 2. Add a new enum for spi type. > >> 3. Improve printk relevant code > >> > >> (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c > >> Parse all kinds of timer in GTDT table of ACPI:arch timer, > >> memory-mapped timer and SBSA Generic Watchdog timer. > >> This driver can help to simplify all the relevant timer drivers, > >> and separate all the ACPI GTDT knowledge from them. > >> > >> (3)Simplify ACPI code for arm_arch_timer > >> > >> (4)Add GTDT support for ARM memory-mapped timer > > > > GTDT is ARM-specific AFAICS. > > yes, you are right, it is. > > > > > If so, why do we need that code to reside in drivers/acpi/ ? > > Although the GTDT is just for ARM64, but this driver is parsing one > of ACPI table, > I think that could be treated as ACPI driver. Do I miss something? :-) Yes, you are. Nobody except for ARM64 will ever need it. Thanks, Rafael From mboxrd@z Thu Jan 1 00:00:00 1970 From: rjw@rjwysocki.net (Rafael J. Wysocki) Date: Thu, 30 Jun 2016 03:37:18 +0200 Subject: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer In-Reply-To: References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org> Message-ID: <5351858.jEb0qfTvrF@vostro.rjw.lan> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday, June 30, 2016 09:29:59 AM Fu Wei wrote: > Hi Rafael, > > On 30 June 2016 at 05:32, Rafael J. Wysocki wrote: > > On Wed, Jun 29, 2016 at 8:15 PM, wrote: > >> From: Fu Wei > >> > >> This patchset: > >> (1)Preparation for adding GTDT support in arm_arch_timer > >> 1. Move some enums and marcos to header file > >> 2. Add a new enum for spi type. > >> 3. Improve printk relevant code > >> > >> (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c > >> Parse all kinds of timer in GTDT table of ACPI:arch timer, > >> memory-mapped timer and SBSA Generic Watchdog timer. > >> This driver can help to simplify all the relevant timer drivers, > >> and separate all the ACPI GTDT knowledge from them. > >> > >> (3)Simplify ACPI code for arm_arch_timer > >> > >> (4)Add GTDT support for ARM memory-mapped timer > > > > GTDT is ARM-specific AFAICS. > > yes, you are right, it is. > > > > > If so, why do we need that code to reside in drivers/acpi/ ? > > Although the GTDT is just for ARM64, but this driver is parsing one > of ACPI table, > I think that could be treated as ACPI driver. Do I miss something? :-) Yes, you are. Nobody except for ARM64 will ever need it. Thanks, Rafael