From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v4 16/21] MAINTAINERS: Add drivers/passthrough/arm Date: Tue, 22 Apr 2014 17:35:24 +0100 Message-ID: <5356B66C020000780000AFB9@nat28.tlf.novell.com> References: <1398172475-27873-1-git-send-email-julien.grall@linaro.org> <1398172475-27873-17-git-send-email-julien.grall@linaro.org> <53568FDB020000780000ADC2@nat28.tlf.novell.com> <5356846F.7060201@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WcdfN-0006T4-PK for xen-devel@lists.xenproject.org; Tue, 22 Apr 2014 16:35:29 +0000 In-Reply-To: <5356846F.7060201@linaro.org> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, Keir Fraser , stefano.stabellini@citrix.com, ian.campbell@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org >>> On 22.04.14 at 17:02, wrote: > On 04/22/2014 02:50 PM, Jan Beulich wrote: >>>>> On 22.04.14 at 15:14, wrote: >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -134,6 +134,7 @@ F: xen/drivers/char/dt-uart.c >>> F: xen/drivers/char/exynos4210-uart.c >>> F: xen/drivers/char/omap-uart.c >>> F: xen/drivers/char/pl011.c >>> +F: xen/drivers/passthrough/arm >> >> This needs a trailing slash, I think. > > The trailing is not necessary (it works correctly for me). I can add it > for consistency. Please do, to clarify this is a directory. > While I was testing this patch, I've noticed that get_maintainer.pl is > considering that you maintain the directory passthrough/arm with Ian C., > Stefano and Tim. Likely because you don't also add X: xen/drivers/passthrough/arm/ to the generic IOMMU section. Jan