From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Wed, 23 Apr 2014 17:30:08 +0200
Subject: [U-Boot] [PATCH 07/11] MX6: use macro building for MX6Q/MX6DL
 iomux regs
In-Reply-To: <CAJ+vNU3B1wEJ6eAQuzPdCsftx6avDqZZrktaz=RBA2NztcoT4w@mail.gmail.com>
References: <1396504871-1454-1-git-send-email-tharvey@gateworks.com>	<1396504871-1454-8-git-send-email-tharvey@gateworks.com>	<53455FDA.3020301@compulab.co.il>
	<CAJ+vNU3B1wEJ6eAQuzPdCsftx6avDqZZrktaz=RBA2NztcoT4w@mail.gmail.com>
Message-ID: <5357DC80.1080603@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tim,

On 09/04/2014 17:46, Tim Harvey wrote:
> On Wed, Apr 9, 2014 at 7:57 AM, Nikita Kiryanov <nikita@compulab.co.il> wrote:
>> Hi Tim,
>>
>>
>> On 04/03/2014 09:01 AM, Tim Harvey wrote:
>>>
>>> This is an attempt at using a macro to allow mx6dl-ddr.h and
>>> mx6q-ddr.h registers to be used together which is needed for an SPL
>>> bootloader
>>> that can run on either CPU's and must configure MMDC iomux dynamically.
>>>
>>> I am trying to come up with a solution similar to Eric's approach with the
>>> similar issue regarding IMX pinmux but this approach is broken in that
>>> imximage
>>> will choke on the cfgtmp file due to the fact that the pre-processor won't
>>> use the enum's as it did the #defines. I'm looking for some positive
>>> suggestions here or perhaps someone else can come up with a solution for
>>> this
>>> particular issue which I haven't been able to resolve.
>>

It seems that this patch breaks all other boards. I tried myself and
after preprocessing the .cfg file, the resulting file contains
structures that mkimage cannot process.

For example, building udoo:

  MKIMAGE u-boot.imx

Invalid imximage commands Type - valid names are: BOOT_FROM,
BOOT_OFFSET, DATA, CSF, IMAGE_VERSION
Error: board/udoo/udoo.cfg.cfgtmp[44] - Invalid command(struct)


In fact, board/udoo/udoo.cfg.cfgtmp contains the structures from
/mx6-ddr.h (this patch):

# 15 "include/config.h" 2
# 23 "board/udoo/udoo.cfg" 2
# 1
"/home/stefano/Projects/imx/u-boot-imx/arch/arm/include/asm/arch/mx6-ddr.h"
1
# 15
"/home/stefano/Projects/imx/u-boot-imx/arch/arm/include/asm/arch/mx6-ddr.h"
struct mx6_mmdc_ioregs {
 u32 mmdc_dram_dqm0;
 u32 mmdc_dram_dqm1;
 u32 mmdc_dram_dqm2;
 u32 mmdc_dram_dqm3;
 u32 mmdc_dram_dqm4;
 u32 mmdc_dram_dqm5;
 u32 mmdc_dram_dqm6;
 u32 mmdc_dram_dqm7;
 u32 mmdc_dram_cas;
 u32 mmdc_dram_ras;

and then mkimage stops.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================