From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com,
tim@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 5/8] tools: arm: prepare for multiple banks of guest RAM
Date: Fri, 25 Apr 2014 13:34:18 +0100 [thread overview]
Message-ID: <535A564A.7060205@linaro.org> (raw)
In-Reply-To: <1398428599.18537.450.camel@kazak.uk.xensource.com>
On 25/04/14 13:23, Ian Campbell wrote:
> On Fri, 2014-04-25 at 13:19 +0100, Julien Grall wrote:
>> Hi Ian,
>>
>> On 25/04/14 12:22, Ian Campbell wrote:
>>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
>>> index 4149d6f..c4f4990 100644
>>> --- a/xen/include/public/arch-arm.h
>>> +++ b/xen/include/public/arch-arm.h
>>> @@ -374,8 +374,12 @@ typedef uint64_t xen_callback_t;
>>>
>>> #define GUEST_MAGIC_BASE 0x39000000ULL
>>>
>>> -#define GUEST_RAM_BASE 0x40000000ULL /* 3GB of RAM @ 1GB */
>>> -#define GUEST_RAM_SIZE 0xc0000000ULL
>>> +#define GUEST_RAM0_BASE 0x40000000ULL /* 3GB of RAM @ 1GB */
>>> +#define GUEST_RAM0_SIZE 0xc0000000ULL
>>> +
>>> +#define GUEST_RAM_BASE GUEST_RAM0_BASE /* Lowest RAM address */
>>
>> Is it necessary to define GUEST_RAM_BASE? I don't see any usage of this
>> define in this patch series.
>
> $ git grep GUEST_RAM_BASE
> tools/libxl/libxl_dom.c:#ifdef GUEST_RAM_BASE
> tools/libxl/libxl_dom.c: if ( (ret = xc_dom_rambase_init(dom, GUEST_RAM_BASE
I forgot this one. Sorry.
Acked-by: Julien Grall <julien.grall@linaro.org>
--
Julien Grall
next prev parent reply other threads:[~2014-04-25 12:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 11:22 [PATCH v2 0/8] xen: arm: support up to (almost) 1TB of guest RAM Ian Campbell
2014-04-25 11:22 ` [PATCH v2 1/8] tools: libxl: use uint64_t not unsigned long long for addresses Ian Campbell
2014-04-25 11:42 ` Julien Grall
2014-04-30 15:12 ` Ian Jackson
2014-04-30 15:49 ` Ian Campbell
2014-05-02 10:03 ` Ian Campbell
2014-04-25 11:22 ` [PATCH v2 2/8] tools: arm: report an error if the guest RAM is too large Ian Campbell
2014-04-25 11:50 ` Julien Grall
2014-04-25 11:51 ` Ian Campbell
2014-04-25 12:01 ` Julien Grall
2014-04-25 12:04 ` Ian Campbell
2014-04-25 11:22 ` [PATCH v2 3/8] tools: arm: move magic pfns out of guest RAM region Ian Campbell
2014-04-25 12:09 ` Julien Grall
2014-04-25 12:22 ` Ian Campbell
2014-04-25 13:10 ` Ian Campbell
2014-04-25 11:22 ` [PATCH v2 4/8] tools: arm: rearrange guest physical address space to increase max RAM Ian Campbell
2014-04-25 12:14 ` Julien Grall
2014-04-25 11:22 ` [PATCH v2 5/8] tools: arm: prepare for multiple banks of guest RAM Ian Campbell
2014-04-25 12:19 ` Julien Grall
2014-04-25 12:23 ` Ian Campbell
2014-04-25 12:34 ` Julien Grall [this message]
2014-04-25 11:22 ` [PATCH v2 6/8] tools: arm: refactor code to setup guest p2m and fill it with RAM Ian Campbell
2014-04-25 12:51 ` Julien Grall
2014-04-25 12:59 ` Ian Campbell
2014-04-25 13:12 ` Julien Grall
2014-04-25 13:22 ` Ian Campbell
2014-04-25 13:28 ` Julien Grall
2014-04-25 11:22 ` [PATCH v2 7/8] tools: arm: support up to (almost) 1TB of guest RAM Ian Campbell
2014-04-25 13:29 ` Julien Grall
2014-04-25 11:22 ` [PATCH v2 8/8] tools: arm: increase size of region set aside for guest grant table Ian Campbell
2014-04-25 12:59 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535A564A.7060205@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.