All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philippe Gerum <rpm@xenomai.org>
To: Matthias Schneider <ma30002000@yahoo.de>,
	"xenomai@xenomai.org" <xenomai@xenomai.org>
Subject: Re: [Xenomai] Issue in notifier_callback while threadobj_lock is being held (forge/mercury)
Date: Sat, 26 Apr 2014 18:13:20 +0200	[thread overview]
Message-ID: <535BDB20.7070100@xenomai.org> (raw)
In-Reply-To: <535B8B43.1000109@xenomai.org>

On 04/26/2014 12:32 PM, Philippe Gerum wrote:

> There is a single sane option: no code running on top of the SIGNOTIFY
> handler should attempt to grab any lock. notifier_callback() is simply
> wrong in acquiring a lock, only to set the suspend bit in the status.
> There is a better option for reflecting the current state locklessly.
>
> I'll issue a fix.
>

Ok, this time I grabbed the chainsaw to fix this code, dropping all 
non-sense and left overs from the early days. Feedback welcome.

http://git.xenomai.org/xenomai-forge.git/commit/?h=next&id=4f3396bf96b9fcb750d68e843c60ec9f5d22f9cd

TIA,

-- 
Philippe.


  reply	other threads:[~2014-04-26 16:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-26  8:58 [Xenomai] Issue in notifier_callback while threadobj_lock is being held (forge/mercury) Matthias Schneider
2014-04-26 10:32 ` Philippe Gerum
2014-04-26 16:13   ` Philippe Gerum [this message]
2014-05-01 11:49     ` Matthias Schneider
2014-05-01 12:52       ` Philippe Gerum
2014-05-01 13:00         ` Philippe Gerum
2014-05-01 14:28           ` Matthias Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535BDB20.7070100@xenomai.org \
    --to=rpm@xenomai.org \
    --cc=ma30002000@yahoo.de \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.