All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Feng Wu <feng.wu@intel.com>
Cc: kevin.tian@intel.com, eddie.dong@intel.com,
	ian.campbell@citrix.com, jun.nakajima@intel.com,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v3 1/9] x86: define CPUINFO_features used as the base offset for cpu features
Date: Mon, 28 Apr 2014 10:13:54 +0100	[thread overview]
Message-ID: <535E37F2020000780000CBC8@nat28.tlf.novell.com> (raw)
In-Reply-To: <535E1788.5080901@citrix.com>

>>> On 28.04.14 at 10:55, <andrew.cooper3@citrix.com> wrote:
> On 28/04/14 04:13, Feng Wu wrote:
>> This patch defines CPUINFO_features which can be used as the base of
>> the offset for cpu features.
>>
>> Signed-off-by: Feng Wu <feng.wu@intel.com>
>> ---
>>  xen/arch/x86/boot/head.S          | 2 +-
>>  xen/arch/x86/x86_64/asm-offsets.c | 2 +-
>>  xen/include/asm-x86/asm_defns.h   | 2 ++
>>  3 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
>> index 1777c17..2b5b26a 100644
>> --- a/xen/arch/x86/boot/head.S
>> +++ b/xen/arch/x86/boot/head.S
>> @@ -131,7 +131,7 @@ __start:
>>          mov     $0x80000001,%eax
>>          cpuid
>>  1:      mov     %edx,sym_phys(cpuid_ext_features)
>> -        mov     %edx,sym_phys(boot_cpu_data)+CPUINFO86_ext_features
>> +        mov     %edx,sym_phys(boot_cpu_data)+CPUINFO_ext_features
> 
> Personally I feel this would be better as CPUINFO_features + 4, rather
> than having another #define in asm_defn.h solely for this purpose.

It should indeed be done here, without the extra #define, but also
without the literal 4. Our main goal here is to collect the LM bit, so
just calculate the number from X86_FEATURE_LM.

Jan

      reply	other threads:[~2014-04-28  9:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28  3:13 [PATCH v3 1/9] x86: define CPUINFO_features used as the base offset for cpu features Feng Wu
2014-04-28  8:55 ` Andrew Cooper
2014-04-28  9:13   ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535E37F2020000780000CBC8@nat28.tlf.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=eddie.dong@intel.com \
    --cc=feng.wu@intel.com \
    --cc=ian.campbell@citrix.com \
    --cc=jun.nakajima@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.