From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 2/2] VT-d: extend error report masking workaround to newer chipsets Date: Mon, 28 Apr 2014 10:56:21 +0100 Message-ID: <535E41E5020000780000CCB0@nat28.tlf.novell.com> References: <535E254A020000780000CA9A@nat28.tlf.novell.com> <535E2702020000780000CACC@nat28.tlf.novell.com> <535E208D.2080805@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WeiIU-00030C-UL for xen-devel@lists.xenproject.org; Mon, 28 Apr 2014 09:56:33 +0000 In-Reply-To: <535E208D.2080805@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: xen-devel , xiantao.zhang@intel.com, Donald D Dugger List-Id: xen-devel@lists.xenproject.org >>> On 28.04.14 at 11:34, wrote: > On 28/04/14 09:01, Jan Beulich wrote: >> Add two more PCI IDs to the set that has been taken care of with a >> different workaround long before XSA-59, and (for constency with the >> newer workarounds) log a message here too. >> >> Also move the function wide comment to the cases it applies to; this >> should really have been done by d061d200 ("VT-d: suppress UR signaling >> for server chipsets"). >> >> This is CVE-2013-3495 / XSA-59. >> >> Signed-off-by: Jan Beulich > > As before, this would probably be better being a conditional message. In any event I want this to be consistent, i.e. I'd want to keep this patch as is and put a third one playing with the verbosity on top. Jan