From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.de, vkoul@kernel.org, gregkh@linuxfoundation.org,
liam.r.girdwood@linux.intel.com, jank@cadence.com,
joe@perches.com, srinivas.kandagatla@linaro.org,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v2 2/2] regmap: soundwire: fix Kconfig select/depend issue
Date: Fri, 3 May 2019 09:32:53 -0500 [thread overview]
Message-ID: <535dfeac-77d8-1307-0329-33b8f2675bbd@linux.intel.com> (raw)
In-Reply-To: <20190503043957.GA14916@sirena.org.uk>
On 5/2/19 11:39 PM, Mark Brown wrote:
> On Fri, Apr 19, 2019 at 02:46:49PM -0500, Pierre-Louis Bossart wrote:
>
>> config REGMAP_SOUNDWIRE
>> tristate
>> - depends on SOUNDWIRE_BUS
>> + select SOUNDWIRE_BUS
>
> This now makes _SOUNDWIRE different to all the other bus types; if this
> is a good change then surely the same thing should be done for all the
> other bus types. It's also not clear to me that this actually does
> anything, do selects from symbols that are themselves selected actually
> do anything?
yes, this works, but if you prefer alignment I can follow the SLIMBUS model
config SND_SOC_WCD9335
tristate "WCD9335 Codec"
depends on SLIMBUS
select REGMAP_SLIMBUS
select REGMAP_IRQ
config REGMAP_SLIMBUS
tristate
depends on SLIMBUS
menuconfig SLIMBUS
tristate "SLIMbus support"
if SLIMBUS
# SLIMbus controllers
config SLIM_QCOM_CTRL
...
As I mentioned it'll compile the bus even if there is no user for it,
but it's your call: alignment or optimization.
next prev parent reply other threads:[~2019-05-03 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 19:46 [PATCH v2 0/2] soundwire: fix Kconfig select/depend issues Pierre-Louis Bossart
2019-04-19 19:46 ` [PATCH v2 1/2] soundwire: fix SOUNDWIRE_BUS option Pierre-Louis Bossart
2019-04-19 19:46 ` [PATCH v2 2/2] regmap: soundwire: fix Kconfig select/depend issue Pierre-Louis Bossart
2019-04-22 6:01 ` Vinod Koul
2019-05-03 4:39 ` Mark Brown
2019-05-03 14:32 ` Pierre-Louis Bossart [this message]
2019-05-06 4:40 ` Mark Brown
2019-05-06 15:28 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535dfeac-77d8-1307-0329-33b8f2675bbd@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=joe@perches.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.