From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753107AbaD3B3S (ORCPT ); Tue, 29 Apr 2014 21:29:18 -0400 Received: from rtits2.realtek.com ([60.250.210.242]:55222 "EHLO rtits2.realtek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbaD3B3P (ORCPT ); Tue, 29 Apr 2014 21:29:15 -0400 X-SpamFilter-By: BOX Solutions SpamTrap 5.39 with qID s3U1SlMu008134, This message is accepted by code: ctloc85258 Message-ID: <536052C9.309@realsil.com.cn> Date: Wed, 30 Apr 2014 09:32:57 +0800 From: micky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Lee Jones CC: , , , , , , , , , Subject: Re: [PATCH 0/2] mmc: rtsx: revert support for mmc async request References: <20140429080240.GC29462@lee--X1> In-Reply-To: <20140429080240.GC29462@lee--X1> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [172.29.41.103] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, On 04/29/2014 04:02 PM, Lee Jones wrote: >> From: Micky Ching >> >> The commit have some problem, >> using mutex_unlock() in atomic context, spinlock deadlock, it is hard to fix >> these problem, and better to use a new method. So just remove it. >> >> The commit depends >> on the previous patch. And mainly fix some problem for the previous patch. So >> need remove. >> >> Micky Ching (2): >> mmc: rtsx: Revert "mmc: rtsx: modify error handle and remove smatch >> warnings" >> mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req" >> >> drivers/mfd/rtsx_pcr.c | 132 ++++------- >> drivers/mmc/host/rtsx_pci_sdmmc.c | 459 +++++++------------------------------ >> include/linux/mfd/rtsx_common.h | 1 - >> include/linux/mfd/rtsx_pci.h | 6 - >> 4 files changed, 124 insertions(+), 474 deletions(-) > Just to clarify, what commit did you base these changes on? Have you > tested to ensure everything works as it should with these two > reversions? > I base on linux-nex tree commit d397246adc001ee5235f32de10db112ad23175df Author: Stephen Rothwell Date: Thu Apr 24 16:22:09 2014 +1000 Add linux-next specific files for 20140424 Signed-off-by: Stephen Rothwell And tested, so it can works ok. Best Regards. micky. From mboxrd@z Thu Jan 1 00:00:00 1970 From: micky Subject: Re: [PATCH 0/2] mmc: rtsx: revert support for mmc async request Date: Wed, 30 Apr 2014 09:32:57 +0800 Message-ID: <536052C9.309@realsil.com.cn> References: <20140429080240.GC29462@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140429080240.GC29462@lee--X1> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Lee Jones Cc: ulf.hansson@linaro.org, sameo@linux.intel.com, gregkh@linuxfoundation.org, linux-mmc@vger.kernel.org, chris@printf.net, linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn, rogerable@realtek.com, devel@linuxdriverproject.org, dan.carpenter@oracle.com List-Id: linux-mmc@vger.kernel.org Hi Lee, On 04/29/2014 04:02 PM, Lee Jones wrote: >> From: Micky Ching >> >> The commit have some problem, >> using mutex_unlock() in atomic context, spinlock deadlock, it is hard to fix >> these problem, and better to use a new method. So just remove it. >> >> The commit depends >> on the previous patch. And mainly fix some problem for the previous patch. So >> need remove. >> >> Micky Ching (2): >> mmc: rtsx: Revert "mmc: rtsx: modify error handle and remove smatch >> warnings" >> mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req" >> >> drivers/mfd/rtsx_pcr.c | 132 ++++------- >> drivers/mmc/host/rtsx_pci_sdmmc.c | 459 +++++++------------------------------ >> include/linux/mfd/rtsx_common.h | 1 - >> include/linux/mfd/rtsx_pci.h | 6 - >> 4 files changed, 124 insertions(+), 474 deletions(-) > Just to clarify, what commit did you base these changes on? Have you > tested to ensure everything works as it should with these two > reversions? > I base on linux-nex tree commit d397246adc001ee5235f32de10db112ad23175df Author: Stephen Rothwell Date: Thu Apr 24 16:22:09 2014 +1000 Add linux-next specific files for 20140424 Signed-off-by: Stephen Rothwell And tested, so it can works ok. Best Regards. micky.