From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
Cc: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>,
Or Gerlitz <or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/mlx4: Allow to always block UD multicast loopback
Date: Thu, 1 May 2014 09:12:23 +0300 [thread overview]
Message-ID: <5361E5C7.5030805@mellanox.com> (raw)
In-Reply-To: <53619638.48ae0e0a.2e40.ffffec09SMTPIN_ADDED_BROKEN-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org>
On 01/05/2014 02:28, Doug Ledford wrote:
> This seems like driving a thumb tack with a sledge hammer. No doubt
> the correct path here is to get the proper flag added to verbs multicast
> attach command. Or, do you still have a patch that does this the
> right way? Did the one from 2008 do it the right way or this way?
Doug, as I commented earlier on this thread, the correct way here is to
carry out the task is to repeat the QP creation flags which we have in
the kernel verbs API for years (see
IB_QP_CREATE_BLOCK_MULTICAST_LOOPBACK in ib_verbs.h and usage in IPoIB)
for the user space verbs API. The patch I provided to Christophand CO
was a band-aid to bring up a whole system on upstream and mlx4 where
this (avoiding multicast loopback) was the only/major missing piece.
The patch posted back in 2008 is proper, but it added a whole new uverb
call/structure, where I think we can get along here with just re-using a
reserved field in the existing uverbs API, see my other post on this thread.
Or.
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-05-01 6:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 18:09 [PATCH] IB/mlx4: Allow to always block UD multicast loopback Christoph Lameter
[not found] ` <alpine.DEB.2.10.1404211308140.29240-gkYfJU5Cukgdnm+yROfE0A@public.gmane.org>
2014-04-21 20:44 ` Or Gerlitz
[not found] ` <CAJZOPZJfdaZ7QzgffzY9Ps-1aUCU+q_dSrj4XfekyfxNa-k+hg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-21 21:06 ` Christoph Lameter
[not found] ` <alpine.DEB.2.10.1404211605390.29907-gkYfJU5Cukgdnm+yROfE0A@public.gmane.org>
2014-04-21 21:10 ` Or Gerlitz
[not found] ` <CAJZOPZ+FwPc3OSVyvk0i4=gX-x0zf_+M8zL1_t9HWmEKi5397Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-22 0:26 ` Christoph Lameter
[not found] ` <alpine.DEB.2.10.1404211926050.31858-gkYfJU5Cukgdnm+yROfE0A@public.gmane.org>
2014-04-22 13:48 ` Christoph Lameter
[not found] ` <alpine.DEB.2.10.1404220844430.4876-gkYfJU5Cukgdnm+yROfE0A@public.gmane.org>
2014-04-22 16:01 ` Or Gerlitz
[not found] ` <53569261.9010805-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-04-29 17:32 ` Christoph Lameter
[not found] ` <alpine.DEB.2.10.1404291231250.26056-gkYfJU5Cukgdnm+yROfE0A@public.gmane.org>
2014-04-30 19:41 ` Or Gerlitz
[not found] ` <CAJZOPZJUksc6f6FMhenWJe5uvEVQ898ZQoLD0ss6vSrMC42ZPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-30 23:18 ` Christoph Lameter
2014-04-30 23:28 ` Doug Ledford
[not found] ` <53619638.48ae0e0a.2e40.ffffec09SMTPIN_ADDED_BROKEN@mx.google.com>
[not found] ` <53619638.48ae0e0a.2e40.ffffec09SMTPIN_ADDED_BROKEN-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org>
2014-05-01 6:12 ` Or Gerlitz [this message]
[not found] ` <5361E5C7.5030805-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-05-01 15:34 ` Doug Ledford
[not found] ` <1980561.1785.1398958457283.JavaMail."DougALedford"@Phenom>
2014-05-05 17:53 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373992F869F-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-05-05 22:54 ` Christoph Lameter
[not found] ` <alpine.DEB.2.10.1405051754260.5069-gkYfJU5Cukgdnm+yROfE0A@public.gmane.org>
2014-05-05 22:57 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373992F899C-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-05-06 0:26 ` Christoph Lameter
2014-05-06 19:16 ` Christoph Lameter
[not found] ` <alpine.DEB.2.10.1405061414460.4548-gkYfJU5Cukgdnm+yROfE0A@public.gmane.org>
2014-05-06 19:25 ` Doug Ledford
[not found] ` <53693749.64db420a.500a.ffffe917SMTPIN_ADDED_BROKEN@mx.google.com>
[not found] ` <53693749.64db420a.500a.ffffe917SMTPIN_ADDED_BROKEN-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org>
2014-05-06 20:08 ` Christoph Lameter
[not found] ` <alpine.DEB.2.10.1405061503550.5175-gkYfJU5Cukgdnm+yROfE0A@public.gmane.org>
2014-05-06 20:20 ` Hefty, Sean
2014-05-06 20:47 ` Doug Ledford
[not found] ` <5361871e.c793420a.67de.2282SMTPIN_ADDED_BROKEN@mx.google.com>
[not found] ` <5361871e.c793420a.67de.2282SMTPIN_ADDED_BROKEN-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org>
2014-05-01 14:09 ` Christoph Lameter
[not found] ` <alpine.DEB.2.10.1405010907570.10334-gkYfJU5Cukgdnm+yROfE0A@public.gmane.org>
2014-05-01 15:32 ` Doug Ledford
[not found] ` <53626915.25fc420a.01b7.7ebbSMTPIN_ADDED_BROKEN@mx.google.com>
[not found] ` <53626915.25fc420a.01b7.7ebbSMTPIN_ADDED_BROKEN-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org>
2014-05-01 15:59 ` Christoph Lameter
[not found] ` <alpine.DEB.2.10.1405011059240.11342-gkYfJU5Cukgdnm+yROfE0A@public.gmane.org>
2014-05-05 17:31 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5361E5C7.5030805@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.