From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Daniel Bristot de Oliveira <bristot@redhat.com>,
<linux-rt-users@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH RT] netconsole: enable netconsole on PREEMPT_RT
Date: Thu, 1 May 2014 10:15:08 -0400 [thread overview]
Message-ID: <536256EC.1060909@windriver.com> (raw)
In-Reply-To: <31fa5b74f8e6267f9b7f906c791d1ddf7d550771.1398788759.git.bristot@redhat.com>
On 14-04-29 01:55 PM, Daniel Bristot de Oliveira wrote:
> Dear RT Folks,
>
> This patch enables the netconsole on PREEMPT_RT_FULL, netconsole
> was disabled on commit:
> cb7cb77 kconfig-disable-a-few-options-rt.patch
>
> I tested the netconsole on three machines:
>
> - Intel Core i5 (4 cpus) - Local network
> - Intel Xeon (32 cpus) - Remote network
> - KVM VM (on a Core i7) - Virtual network
Chances are the two real targets above were using the
same igb network driver. I wonder if it matters what
underlying nic is used for netconsole?
It is probably worthwhile to do some data mining into why
it was disabled in the 1st place. I can't say I recall, and
it is possible that the reason has long since become irrelevant,
even though the patch has been carried forward over time.
Or it may be that your testing simply doesn't cover the use
case where netconsole will spew sleeping while atomic...
P.
--
>
> On these machines I build the kernel 3.10.34-rt34 + netconsole
> built as module. In order to execute some printks, I run a small
> benchmark that runs as a module. To analyse the output I captured
> the netconsole messages using Wireshark.
>
> On all cases, the tests passed without any error:
>
> - No error messages from the kernel
> - No missed messages
> - No out of order messages
>
> I ran +1 hour tests on each machine. The test using the Xeon machine
> ran by around 10 hours. On this test I received 317149 netconsole's
> messages.
>
> I also read the code and ran some traces (using the ftrace's
> function_graph). In the traces that I read, the netconsole code never
> broke the rt lock assumptions.
>
> Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
> ---
> drivers/net/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 096de88..3835321 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -164,7 +164,6 @@ config VXLAN
>
> config NETCONSOLE
> tristate "Network console logging support"
> - depends on !PREEMPT_RT_FULL
> ---help---
> If you want to log kernel messages over the network, enable this.
> See <file:Documentation/networking/netconsole.txt> for details.
>
next prev parent reply other threads:[~2014-05-01 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 17:55 [RFC PATCH RT] netconsole: enable netconsole on PREEMPT_RT Daniel Bristot de Oliveira
2014-05-01 14:15 ` Paul Gortmaker [this message]
2014-05-05 19:10 ` Daniel Bristot de Oliveira
2014-05-09 15:55 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536256EC.1060909@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=bristot@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.