From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wfrzl-0000r8-I9 for qemu-devel@nongnu.org; Thu, 01 May 2014 10:29:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wfrzh-0002A3-1I for qemu-devel@nongnu.org; Thu, 01 May 2014 10:29:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wfrzg-00029u-OJ for qemu-devel@nongnu.org; Thu, 01 May 2014 10:29:48 -0400 Message-ID: <53625A4E.8050705@redhat.com> Date: Thu, 01 May 2014 08:29:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1396605482-8720-1-git-send-email-arei.gonglei@huawei.com> <1396605482-8720-7-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1396605482-8720-7-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="noQw9bsrxud16c29eTdT2e9wf5HfwDhRh" Subject: Re: [Qemu-devel] [PATCH v5 06/10] XBZRLE: rebuild the cache_is_cached function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: ChenLiang , weidong.huang@huawei.com, quintela@redhat.com, dgilbert@redhat.com, owasserm@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --noQw9bsrxud16c29eTdT2e9wf5HfwDhRh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/04/2014 03:57 AM, arei.gonglei@huawei.com wrote: > From: ChenLiang >=20 > Rebuild the cache_is_cached function by cache_get_by_addr. And > drops the asserts because the caller is also asserting the same > thing. Technically, the caller (parent - arch_init.c:save_xbzrle_page) is not asserting the same thing; rather, it is the callee (child - cache_get_by_addr() used first in the two methods where you dropped the asserts) that is making the same assertion. >=20 > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > Reviewed-by: Dr. David Alan Gilbert > --- > page_cache.c | 38 ++++++++++++++++---------------------- > 1 file changed, 16 insertions(+), 22 deletions(-) The commit message can be trivially amended; so Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --noQw9bsrxud16c29eTdT2e9wf5HfwDhRh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTYlpOAAoJEKeha0olJ0NqxjIIAINYgr4mccJSQ2uJq2qC5slN KZol09Ge9WS5wlxMMCxhR234Bri0vVr5EOhgl2AuLb0Y+78RxGayJbmtCjh7wHhk cDD6DNRCZG5OB9zok917FmVXNfp1h+5O8fbMASYWmWpgX9dmQlqOi0hNCI7oit18 xXk32QW5yKh2RgCvUW0vHt2TjoJMTBPQUO4L2QPkLaM7eJ795bFeIGYQtvBEOZkD x7zXOyFZI8+BPcGfzyuuYKnN6LSRasvj7M7kil67q1ZoBwgfuvmuh72vL3t2saVg AB8xesIuvjvQd6nOI+e9pnyHE1rIK+uXdtCjuvHZGIaX1n27WstiuFSLOZXf730= =psem -----END PGP SIGNATURE----- --noQw9bsrxud16c29eTdT2e9wf5HfwDhRh--