From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wfs7q-0003MY-PR for qemu-devel@nongnu.org; Thu, 01 May 2014 10:38:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wfs7m-00063X-Lk for qemu-devel@nongnu.org; Thu, 01 May 2014 10:38:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wfs7m-00063J-Dn for qemu-devel@nongnu.org; Thu, 01 May 2014 10:38:10 -0400 Message-ID: <53625C4E.3010401@redhat.com> Date: Thu, 01 May 2014 08:38:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <1398918422-3019-1-git-send-email-wenchaoqemu@gmail.com> <1398918422-3019-5-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1398918422-3019-5-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mA6iw7bt7K4dO2jCuaftSEtnoTCopioPG" Subject: Re: [Qemu-devel] [PATCH V5 04/28] test: add test cases for qapi event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mA6iw7bt7K4dO2jCuaftSEtnoTCopioPG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/30/2014 10:26 PM, Wenchao Xia wrote: > These cases will verify whether the expected qdict is built. >=20 > Signed-off-by: Wenchao Xia > --- > tests/Makefile | 14 ++- > tests/qapi-schema/qapi-schema-test.json | 12 ++ > tests/qapi-schema/qapi-schema-test.out | 10 +- > tests/test-qmp-event.c | 265 +++++++++++++++++++++++= ++++++++ > 4 files changed, 296 insertions(+), 5 deletions(-) > create mode 100644 tests/test-qmp-event.c >=20 > @@ -232,12 +236,16 @@ $(SRC_PATH)/tests/qapi-schema/qapi-schema-test.js= on $(SRC_PATH)/scripts/qapi-typ > tests/test-qapi-visit.c tests/test-qapi-visit.h :\ > $(SRC_PATH)/tests/qapi-schema/qapi-schema-test.json $(SRC_PATH)/script= s/qapi-visit.py > $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-visit.py $(ge= n-out-type) -o tests -p "test-" < $<, " GEN $@") > +tests/test-qapi-event.c tests/test-qapi-event.h :\ > +$(SRC_PATH)/tests/qapi-schema/qapi-schema-test.json $(SRC_PATH)/script= s/qapi-event.py > + $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-event.py $(ge= n-out-type) -o tests -p "test-" < $<, " GEN $@") I'd like to see Llu=C3=ADs' modularization patches go in first, which mea= ns this should be rebased to break into shorter lines and to pass the name of the file as an input parameter rather than parsing it from stdin. https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg05069.html But everything else here seems okay. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mA6iw7bt7K4dO2jCuaftSEtnoTCopioPG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTYlxOAAoJEKeha0olJ0NqxfgIAJvGeqIRhUJkrIQUaGcXAfDq 8G8G9YdHqQIcWMSQAzQb+ZlxpT4opmshIWZEQP6h+iPr6av3nsJKsb6/LUotjWG8 bCl0+E5Wx+RLOyWGFUL+bQ7GIIVh/DuMRtbLgBony6VFYaxEAcs1QStEuOjzyx20 kaR/3rSpXtkZuh5KvmtksJ4pGmjFjH2y7q/uX7JFJQhYBRlw068HMv1bAt12mAtO ffzPHxVwk/t3sHGvzRgbXJhKWDNPPvV3a2njqt0WZCrPTfD2RUDoLpVmNQB6FN2b 2QzNR+wBbyJQL6AVm2mwknYtn7Qn+LMUCXTpPSxPiL8ICLDLg7c9p0mBLp026Xk= =4bXu -----END PGP SIGNATURE----- --mA6iw7bt7K4dO2jCuaftSEtnoTCopioPG--