From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfsDy-0005Gj-7i for qemu-devel@nongnu.org; Thu, 01 May 2014 10:44:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WfsDt-00087i-AI for qemu-devel@nongnu.org; Thu, 01 May 2014 10:44:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfsDt-00087b-1g for qemu-devel@nongnu.org; Thu, 01 May 2014 10:44:29 -0400 Message-ID: <53625DC4.6040000@redhat.com> Date: Thu, 01 May 2014 08:44:20 -0600 From: Eric Blake MIME-Version: 1.0 References: <1398918422-3019-1-git-send-email-wenchaoqemu@gmail.com> <1398918422-3019-8-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1398918422-3019-8-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mbxdLk31ParL5GUofB11QG4b0dwa8TiOT" Subject: Re: [Qemu-devel] [PATCH V5 07/28] qapi event: convert SHUTDOWN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mbxdLk31ParL5GUofB11QG4b0dwa8TiOT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/30/2014 10:26 PM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > vl.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) This, and many of the subsequent patches in the series, are a bit misleading; I have to go back to 5/28 to make sure that both pieces of the conversion are in sync. Is there a technical reason why you can't provide both the qapi definition and the conversion to the new qapi_event_send_FOO function in the same patch, one patch per FOO, rather than your current split? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mbxdLk31ParL5GUofB11QG4b0dwa8TiOT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTYl3EAAoJEKeha0olJ0NqjAwIAIVjRTlleYYc8aOR+BL66C+e CnfgXnEQUiUjTt1LbUCPSwSBm3SteWjxfRIA8ZedHO9wV4AwxgT4M4GTYZLmatxn waoBZFa/StigS8vslzLSBogkNKhXrjdklRBqpYzQU6dlf+Pp9AUkeUybpVkXBUoD zgonCzg2YbVh7GrHXPvEDW9eb/fuAnz2JFn5PiIyLetmL/pq5ubBnTh9c+E7wpqs rTItIFa9kJ0myEMGO7qzt6LaxV5x7YJ8yrQAcKmB0F6+IkD0YE+fUi8xzE3x++aR VxZanI3f0bviyN+y9RjNfXRQLb+y8jUOe2bett8GCi3pPB7sovT1UdVa8cjQ9fk= =DiI9 -----END PGP SIGNATURE----- --mbxdLk31ParL5GUofB11QG4b0dwa8TiOT--