From mboxrd@z Thu Jan  1 00:00:00 1970
From: York Sun <yorksun@freescale.com>
Date: Thu, 1 May 2014 08:47:11 -0700
Subject: [U-Boot] [PATCH 1/8] kmp204x: Add support for the unit LEDs
In-Reply-To: <53625390.6060105@keymile.com>
References: <1398862909-17580-1-git-send-email-valentin.longchamp@keymile.com>
	<1398862909-17580-2-git-send-email-valentin.longchamp@keymile.com>
	<53612D08.4030508@freescale.com> <53625390.6060105@keymile.com>
Message-ID: <53626C7F.6010403@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 05/01/2014 07:00 AM, Valentin Longchamp wrote:
> Hi York,
> 
> On 04/30/2014 07:04 PM, York Sun wrote:
>> On 04/30/2014 06:01 AM, Valentin Longchamp wrote:
>>> From: Stefan Bigler <stefan.bigler@keymile.com>
>>
>> <snip>
>>
>>> diff --git a/board/keymile/kmp204x/qrio.c b/board/keymile/kmp204x/qrio.c
>>> index 49f9aa2..11949f4 100644
>>> --- a/board/keymile/kmp204x/qrio.c
>>> +++ b/board/keymile/kmp204x/qrio.c
>>> @@ -144,3 +144,17 @@ void qrio_prstcfg(u8 bit, u8 mode)
>>>  
>>>  	out_be32(qrio_base + PRSTCFG_OFF, prstcfg);
>>>  }
>>> +
>>> +#define CTRLH_OFF		0x02
>>> +#define CTRLH_WRL_BOOT		0x01
>>> +#define CTRLH_WRL_UNITRUN	0x02
>>> +
>>> +void qrio_set_leds(void)
>>> +{
>>> +	u8 ctrlh;
>>> +	void __iomem *qrio_base = (void *)CONFIG_SYS_QRIO_BASE;
>>
>> Please insert a blank line here.
> 
> OK, that's correct. Do you want me to resend the whole series or are the first 2
> patches with the additional blank line OK ?
> 

For a simple change like this, you can do either way. Make sure to change the
subject prefix so it doesn't confuse me or anyone.

York